[pull] master from DataDog:master#517
Merged
Merged
Conversation
…er-side prefixes (#23556) * [kafka_actions] support skipping a fixed number of bytes before deserialization Adds value_skip_bytes and key_skip_bytes to read_messages config. When non-zero, the deserializer drops that many bytes from the start of the record before doing any further work (raw / json / bson / protobuf / avro decoding, and Confluent Schema Registry magic-byte detection). Use case: producers commonly prepend a fixed-size envelope to the payload — a 1-byte version flag, a 4-byte tenant id, a non-Confluent schema-registry header, an application-level compression marker — that the integration's existing format paths don't recognize. Stripping a known fixed prefix lets the rest decode cleanly without adding a new format-specific code path for every variant. Default 0 (no bytes skipped); negative values and values exceeding the message length return clear deserialization errors instead of truncating silently. * [kafka_actions] restore trusted-provider check for TLS fields in instance.py The previous commit ran ddev validate models with an older ddev (14.3.0) that doesn't recognize the require_trusted_provider flag in spec.yaml. The regenerated instance.py dropped both the SECURE_FIELD_NAMES set and the validation.security.check_field_trusted_provider call from the field _validate branch, regressing the security enforcement on: schema_registry_tls_ca_cert, schema_registry_tls_cert, schema_registry_tls_key, tls_ca_cert, tls_cert, tls_private_key. For remote/fleet-configured instances, untrusted config could again supply local file paths for sensitive TLS material. Restoring the SECURE_FIELD_NAMES frozenset and the security check matches what master's instance.py looked like before this PR. Spec.yaml already declares require_trusted_provider: true on these fields; only the generated mirror needed restoring. * [kafka_actions] fix lint formatting and add changelog Apply ruff format to message_deserializer.py and tests, and add the changelog entry required by the PR check.
…er framework (#23530) * [datadog_checks_base] Add include_total option for Windows perf-counter framework Add a per-performance-object include_total option (default false) to the Windows perf-counter framework. When set to true, the _Total aggregate instance is no longer excluded by default and can be collected. The previous behaviour (always exclude _Total) is preserved, so this is strictly opt-in and backwards-compatible. * Rename changelog stub to PR number * Fix CI: changelog, formatting, regenerated spec models - Add datadog_checks_dev changelog entry for the perf_counters template change - Reformat counter.py and test_filter.py per ruff 0.11.10 - Regenerate config_models/instance.py and data/conf.yaml.example for the 7 integrations using the perf_counters template (active_directory, aspdotnet, dotnetclr, exchange_server, hyperv, iis, windows_performance_counters) so that include_total is exposed. * Add per-integration changelog entries for include_total exposure
* Update README to reflect legacy status and recommendations Added a callout about the legacy status of the DCGM integration and recommended using Datadog's GPU Monitoring for better insights. * Update dependency resolution * Fix typo: "noy" -> "not" Signed-off-by: Kathy L. <kathy.lin@datadoghq.com> * Update dcgm/README.md Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com> * Update dcgm/README.md Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com> --------- Signed-off-by: Kathy L. <kathy.lin@datadoghq.com> Co-authored-by: dd-agent-integrations-bot[bot] <dd-agent-integrations-bot[bot]@users.noreply.github.com> Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
…uration (#23581) * Use parameterized queries for replication channel configuration to safely handle special characters in channel names * Fix linting * Add changelog * Fix changelog
* Remove incorrect SQL Server links * Update supported versions * Update mysql version of docs linked
The image widget was pointing to /api/v2/images/<UUID>, which is the per-org image upload API. The UUID only resolved in the demo org where the dashboard was originally built, so the image was missing for all customers (reported on prod and staging). Switch to the static asset path used by sibling integrations (e.g. Cisco SD-WAN), which is org-agnostic and ships with web-ui. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )