[pull] master from DataDog:master#518
Merged
Merged
Conversation
* Add out_of_sync_broker_id tag to Kafka partition metrics When `enable_cluster_monitoring` is true, emit an `out_of_sync_broker_id:<id>` tag on the kafka.partition.* metrics for each replica that is assigned to the partition but not present in the ISR. Fully-replicated partitions are unchanged (no new tags emitted), preserving existing dashboards and alerts. This lets operators query kafka.partition.under_replicated (or the other partition metrics) grouped by out_of_sync_broker_id to attribute under- replicated partitions to specific broker IDs. * Update style and test coverage to address feedback * Assert out_of_sync_broker_id tag on all shared partition gauges
* fix(nutanix): emit vm.disk_capacity_bytes from VM config The metric was previously mapped from `diskCapacityBytes` in VM_STATS_METRICS, but the Nutanix v4 stats endpoint never returns that field, so the metric was effectively never emitted (and was parked in VM_STATS_METRICS_OPTIONAL, which silently let it slip). Source it from the VM config instead: sum vm.disks[].backingInfo.disk SizeBytes, the same approach memory.allocated_bytes uses for memorySizeBytes. Move the metric from VM_STATS_METRICS_OPTIONAL into VM_CAPACITY_METRICS so the test framework now enforces emission. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(nutanix): add changelog fragment for vm.disk_capacity_bytes fix Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(nutanix): trim disk_capacity_bytes changelog to one line Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )