[pull] master from DataDog:master#52
Merged
Merged
Conversation
* vendor gstatus * fix mocks * fix unit tests and mocks * remove gstatus from Dockerfile * add CheckVMLogs helper * add support for vm_run context manager * test with glusterfs integration * cleanup CheckVMLogs implementation * WIP: working VM setup + agent install , working ddev env agent commands * working check command and config mounting * add support for vagrant in env_type in the plugin README * fix glusterfs init config * add gluster volumes -> E2E tests passing * fix glusterfs version to 7 * revert plugin/pytest.py single quote -> double quote changes * remove unnecessary formatting file changes * clean README changes * add comment for CheckVMLogs condition * remove quote -> double quotes changes * conftest cleanup * add support for custom agent build via pipeline-id * wip: fix pip install command for local package * working --dev flag for local package installation * fix agent_env_vars keyword name and cleanup code * add support for custom memory and cpus for the vagrant VM * fix exporting env vars + fix vm cpus and memory fields error * add env metadata key * small cleanup * refactor + fix dd_hostname handling * more cleanup + fix agent restart cmd + use jinja for VagrantFile template * remove checkVMLogs unused conditions * revert deleting the conditions.py file, only delete the new CheckVMLogs function * lint * fix version number committed by accident * wip * fix --dev local package installation, fix agent service restart, remove exception LOL from check.py for testing, fix linting, fix e2e test * fix sudeoers config interface, fix sudoers bug in format and file name, fix glusterfs monkey patching, fix linting * lint * ddev dep freeze * add paramiko dependency to ddev * SKIP E2E tests on CI for glusterfs * fix SKIP E2E tests on CI for glusterfs * one more attempt to skip e2e tests on CI * skip env provisioning when agent_type is vagrant on CI for the start command * fix running_on_ci check * remove paramiko * add support for %HOST% template var and fix post_install_commands * always install glusterfs 11.1 * address review comments + refactor * delete test_version_metadata from the e2e test * improve logging, fix lint, fix commands output, use self.platform subprocess functions * more refactoring and code cleanup, and logs improvements * refactor start method into smaller methods + cleanup * update AgentInterface to pass Application instead of Platform, and use application global logging system instead of logging library * remove unnecessary logging when raising exception * add VM hostname prefix to run_command debug logging * add validation and proper error message around agent_build format * fix env reload command to only restart the agent service, not the entire VM, remove hash diff logic and provision flag * remove unused _show_logs method, and fix stderr logging level to be error * fix redundant log message of vagrant file generation, fix vagrant file initializing logic * use ddev storage_dir to store the vagrant file * fix exported_env_vars and propagate the right ddev config API keys * add test_vagrant.py + FIX windows bugs * improve test names * use %HOST% variable in glusterfs start_commands * improve logging messages * Apply suggestions from code review Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com> * fix type hints * remove unused constants * nit * apply suggestion to parametrize OS specific unit tests * fix installing local packages on windows -> fix pip command * remove glusterfs changes from this branch * remove more glusterfs changes * ddev lint * changelog * Add Vagrant section in developer docs Test Framework * fix vagrant link * revert dcd changes * remove dcd changes * remove get_id definition from VagrantAgent * move re import to the top * remove halt vm and destroy vm vars * addressing review: oneliner guest_cmds and remove interactive bool from format command * addressing review: small code improvement * addressing review: add a comment about not using pathlib * adressing review: move variable closer to where its used * adressing review: remove redundant variables * remove unused template variable for dd_api_key * remove unnecessary comments and unsued param --------- Co-authored-by: dkirov-dd <166512750+dkirov-dd@users.noreply.github.com>
* Make config publically available * Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )