[pull] master from DataDog:master#574
Merged
Merged
Conversation
* Add broker list to kafka_consumer cluster monitoring heartbeat Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Add changelog entry for PR #23898 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Address review comments on heartbeat broker list - Extract _get_broker_list() helper to separate topology-transform from payload-assembly - Use broker_meta.id instead of dict key; cast to str to match broker config event convention - Add tests for heartbeat brokers payload (populated and empty cases) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix _cluster_metadata not set on create_autospec mock in tests seed_mock_kafka_client uses create_autospec(KafkaClient), which does not expose instance attributes set in __init__. Setting _cluster_metadata directly on the mock fixture makes it available to _get_broker_list(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )