[pull] master from DataDog:master#589
Merged
Merged
Conversation
* Update dd-octo-sts policy for resolve build deps * revert workflow change
… absent (#23951) * kafka_actions: fall back to string when schema registry magic byte is absent When uses_schema_registry=True but the first byte of a message is not 0x00, the deserializer now decodes the message as a plain UTF-8 string instead of raising an error. This handles producers that mix framed and unframed messages on the same topic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * kafka_actions: add changelog entry for PR #23951 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * kafka_actions: simplify SR fallback — debug log, no raise, cleaner condition - Replace warning with debug log - Single condition: len >= 5 && magic byte == 0x00 → SR path, else → string fallback - No ValueError raised for any non-SR message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * kafka_actions: remove msg_hex from debug log Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * kafka_actions: fix lint errors (E501, I001) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * kafka_actions: fix remaining I001 import sort errors using root pyproject.toml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* Make statement_timeout local for Postgres schemas * Changelog * Disable autocommit for schemas * Manually set autocommit * Manually commit * Try/finally * with transaction * Disable in tests
…meout (#23896) * data observability postgres: respect rc-passed transaction timeout Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> * timeout, yaml parse Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> * remove unrelated tests Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> * postgres/do: rename timeout_seconds to query_timeout, fix SET LOCAL binding Rename `timeout_seconds` → `query_timeout` in the DO query spec to align with the existing `query_timeout` instance config. Replace `cursor.execute("SET LOCAL statement_timeout = %s", ...)` with `cursor.execute("SELECT set_config('statement_timeout', %s, true)", ...)` to avoid psycopg3 server-side binding rejection: psycopg3 uses the extended query protocol for parameterized execute() calls, and PostgreSQL rejects bound parameters in SET statements under that protocol. set_config() accepts parameters normally; is_local=true gives identical scope to SET LOCAL. Also remove the now-unnecessary _loaded_config_id tracking: the whole check is rescheduled when the RC payload changes, so _last_execution is always fresh on a new instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> * postgres/do: fix test execute_side_effect filter for set_config The test was filtering on 'SET LOCAL' to skip the timeout-setting execute, but after replacing SET LOCAL with set_config() the filter no longer matched, causing query_count to increment on the set_config call and shifting description assignments off by one. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> * query_timeout in milliseconds Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> --------- Signed-off-by: mobuchowski <maciej.obuchowski@datadoghq.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* Scaffolding * validate * update labeler * format * update changelog * Add can_connect metric * lint * collect system and system statistics * Add API component * Add support for volumes * Simplify code * Add support for storage pools * simplify code * Add support for protection domains * Add sds support * parameterize exception test * Add sdc metrics * Add device metrics * Add common metrics * remove resource prefix and tag by resource * Add auth token config * Add resource filters and events * handle token workflow * update event query and fix tests * Add support for alerts * change to last updated * Add more storage pool metrics * rename constants * address comments and clean up tests * Address more feedback * simplify code more * remove dead code and add test for unauthenticated mode * Add overrides and sync models * validate * Add more debug logging and add collect_events_and_alerts function * replace direct access with .get * fix types * fix tag fallback * update constant naming and spacing, device statistics powered off by default * Add test for device disabled by default * Add severity remapping * Allow multiple filters per resource * match nutanix and vsphere filters better * Add e2e * Fix types * validate config * fill coverage gaps and more types * Add comment for get_alerts * Add count metric for each resource and fix resource filters bug * use min collection interval to handle expiry and also handle api errors gracefully * remove unneeded tests * clean up tests * more test cleanup * remove unneeded test * fix style * apply user defined tags and fix metadata * remove unneeded defaults * validate ci * lint * ignore type * Add thread pool * lint * add exception case and remove unneeded ensure auth * ensure auth first, and update tests accordingly * update readme and event source * Address comments * Add loop to simplify tests * update metadata with suggestions * Apply suggestions from code review Co-authored-by: Alicia Thuerk <alicia.thuerk@datadoghq.com> * update coverage * Refactor constants and assert all metrics and tags in unit and e2e test * Add scope * Harden test * Add another test case * update config * Fix metadata and fix filter fallback * Add type * Handle exception better * Add catch all exception handling and fix types * Add stack trace debug line * fix e2e test * remove unneeded ALL_METRICS * Fix E2E test and clean up constants * lint * Fix types * address comments --------- Co-authored-by: Alicia Thuerk <alicia.thuerk@datadoghq.com>
* submit general resource via checks base * wording * changelog * lint * small nits * rework genresource submission * Rename 23818.added to 23905.added * rename * include INCLUDE_ALL * address some comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )