[pull] master from DataDog:master#621
Merged
Merged
Conversation
* Add group_per_user_services option to windows_service Strip the per-session LUID suffix from Windows per-user service instances so they report under their template name, reducing windows_service and display_name tag cardinality. Detection gates on the SERVICE_USERSERVICE_INSTANCE type flag plus a trailing _<LUID> suffix. Defaults to false. * Address review: type hints, comment, filter-mode test Add type hints to _group_per_user_service_name and drop the redundant suffix-search guard. Document the grouped-instance behavior (instances collapse to one series; last-emitted state wins) as a code comment. Add a test covering grouping when services are selected by name filter. * Add changelog entry * Reuse ServiceAssertion in group_per_user tests Use the existing ServiceAssertion / assert_service_check_and_metrics helpers in the group_per_user tests for consistency with the rest of the suite; this also asserts the uptime/state/restarts metrics, not just the service check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )