Skip to content

Commit 3d418eb

Browse files
committed
Remove the opcache option from the real-time benchmark workflow
It's not needed anymore since it's now always turned on, and the exact usage (whether to use --enable-opcache or not) is automatically detected: kocsismate/php-version-benchmarks@0b11664 [skip-ci]
1 parent a7abaa0 commit 3d418eb

1 file changed

Lines changed: 0 additions & 27 deletions

File tree

.github/workflows/real-time-benchmark.yml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,6 @@ on:
2424
options:
2525
- "0"
2626
- "1"
27-
opcache:
28-
description: 'Whether opcache is enabled for the benchmarked commit'
29-
required: true
30-
default: "1"
31-
type: choice
32-
options:
33-
- "0"
34-
- "1"
35-
- "2"
36-
baseline_opcache:
37-
description: 'Whether opcache is enabled for the baseline commit'
38-
required: true
39-
default: "1"
40-
type: choice
41-
options:
42-
- "0"
43-
- "1"
44-
- "2"
4527
run_micro_bench:
4628
description: 'Whether to run the micro_bench.php test'
4729
required: true
@@ -67,8 +49,6 @@ jobs:
6749
COMMIT: ${{ github.sha }}
6850
BASELINE_COMMIT: "d5f6e56610c729710073350af318c4ea1b292cfe"
6951
ID: "master"
70-
OPCACHE: "1"
71-
BASELINE_OPCACHE: "2"
7252
JIT: "1"
7353
INSTRUCTION_COUNT: "1"
7454
RUN_MICRO_BENCH: "0"
@@ -100,8 +80,6 @@ jobs:
10080
10181
echo "ID=benchmarked" >> $GITHUB_ENV
10282
103-
echo "OPCACHE=${{ inputs.opcache }}" >> $GITHUB_ENV
104-
echo "BASELINE_OPCACHE=${{ inputs.baseline_opcache }}" >> $GITHUB_ENV
10583
echo "JIT=${{ inputs.jit }}" >> $GITHUB_ENV
10684
echo "INSTRUCTION_COUNT=${{ inputs.instruction_count }}" >> $GITHUB_ENV
10785
echo "RUN_MICRO_BENCH=${{ inputs.run_micro_bench }}" >> $GITHUB_ENV
@@ -179,7 +157,6 @@ jobs:
179157
PHP_BRANCH=${{ env.BRANCH }}
180158
PHP_COMMIT=${{ env.BASELINE_COMMIT }}
181159
182-
PHP_OPCACHE=${{ env.BASELINE_OPCACHE }}
183160
PHP_JIT=0
184161
EOF
185162
- name: Setup PHP config - baseline PHP version with JIT
@@ -197,7 +174,6 @@ jobs:
197174
PHP_BRANCH=${{ env.BRANCH }}
198175
PHP_COMMIT=${{ env.BASELINE_COMMIT }}
199176
200-
PHP_OPCACHE=${{ env.BASELINE_OPCACHE }}
201177
PHP_JIT=${{ env.JIT }}
202178
EOF
203179
@@ -223,7 +199,6 @@ jobs:
223199
PHP_BRANCH=${{ env.BRANCH }}
224200
PHP_COMMIT=$LAST_RESULT_SHA
225201
226-
PHP_OPCACHE=1
227202
PHP_JIT=0
228203
EOF
229204
- name: Setup PHP config - benchmarked PHP version
@@ -238,7 +213,6 @@ jobs:
238213
PHP_BRANCH=${{ env.BRANCH }}
239214
PHP_COMMIT=${{ env.COMMIT }}
240215
241-
PHP_OPCACHE=${{ env.OPCACHE }}
242216
PHP_JIT=0
243217
EOF
244218
- name: Setup PHP config - benchmarked PHP version with JIT
@@ -254,7 +228,6 @@ jobs:
254228
PHP_BRANCH=${{ env.BRANCH }}
255229
PHP_COMMIT=${{ env.COMMIT }}
256230
257-
PHP_OPCACHE=${{ env.OPCACHE }}
258231
PHP_JIT=${{ env.JIT }}
259232
EOF
260233

0 commit comments

Comments
 (0)