Skip to content

[pull] master from php:master#17

Merged
pull[bot] merged 6731 commits intoConnectionMaster:masterfrom
php:master
Jul 7, 2025
Merged

[pull] master from php:master#17
pull[bot] merged 6731 commits intoConnectionMaster:masterfrom
php:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Mar 14, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Girgias and others added 30 commits July 6, 2025 17:21
To make it easier for IDEs to understand what is going on
This is unnecessary now that the session name is a zend_string
This clarifies intention and uses less bytes in the struct
The `defaultMemoryManager` is only available via a non-public
header and is not supposed to be used by users of the library [1].
It also has a very generic name, further indicating that it is not
supposed to be used.

Instead pass the memory manager explicitly, which is how the library is
supposed to be used.

[1] uriparser/uriparser#52 (comment)
This also omits defining unused HAVE_WINSOCK_H macro when building
ext/sockets.
re2c version 4 enabled some warnings by default. This fixes re2c code
for the `-Wuseless-escape` warnings.

There are two same issues reported.
Issue: GH-17523
Closes: GH-17204
* PHP-8.3:
  Fix -Wuseless-escape warnings emitted by re2c (#19050)
* PHP-8.4:
  Fix -Wuseless-escape warnings emitted by re2c (#19050)
Since `ZSTR_LEN()` returns a `size_t` (unsigned integer), the value can only be either "not equal to 0" or "equal to 0". The third `else` branch was unreachable, making the `*handled_output = NULL;` assignment dead code.
IR commit: af6dc83bcd91c3123f40efcdcbeba8794b9b2abf
* PHP-8.4:
  Update IR
* PHP-8.3:
  [skip ci] Add missing zlib dep to phar compression test
* PHP-8.4:
  [skip ci] Add missing zlib dep to phar compression test
This check is related only to ext/posix so it's more clear to have it
defined when ext/posix is enabled.
…#19029)

Have each of the specialized methods for registering a constant return a
pointer to the registered constant the same way that the generic
`zend_register_constant()` function does, and use those in the generated
arginfo files to avoid needing to search for a constant that was just
registered in order to add attributes to it.
…hecks (#18995)

* Zend: Add `zend_check_method_accessible()` to DRY method visibility checks

* Zend: Add assertions verifying flags didn't change before `zend_check_method_accessible()`

* Try `zend_always_inline` for `zend_check_method_accessible`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.