[V4] Cancellation 2.0 (#72)

* sketch

* spell

* await suspend

* in final suspend

* todo

* root declares what it is

* final suspend loop on cancel

* restore assert

* remove pre-suspend check

* owning parent

* return adr abstraction

* Revert "owning parent"

This reverts commit 81fb23b.

* extra template param in pkg

* op overloads

* check return is non null

* todo

* cancel propagation

* PERF: move propagation to await_transform

* PERF: move check

* Revert "PERF: move check"

This reverts commit 37f99b5.

* Revert "PERF: move propagation to await_transform"

This reverts commit b3ec305.

* split final suspend

tripple final suspend

* Revert "remove pre-suspend check"

This reverts commit a2af5da.

* Reapply "remove pre-suspend check"

This reverts commit 953975b.

* drop inline forcing

* revert owner split release

* unranched

* Revert "unranched"

This reverts commit c80f7d7.

* unique types in pkg

* comments

* better names

* rm comments

* full pre-release

* full fused release

This reverts commit fe90470.

* Revert "full fused release"

This reverts commit 764b6d8.

* double branch reduced

* Revert "double branch reduced"

This reverts commit 12bb9c5.

* fixup negation

* fixup todo

* refactor names of final suspend parts

* set cancellation in await suspend

* unconditional cancel test

* bad

* Revert "bad"

This reverts commit fcc1924.

* Revert "unconditional cancel test"

This reverts commit 20141ee.

* rm comment

* constify

* add todo

* add todo

* cancel test

TMP: cancel branch

tests

format

add joins

fuzz

more fuzz

format

tigher structure for agents

drop all ref to lints

fix conditional

* join cancel fix

* cancel fuzz

* fix conditional

* agents tweaks

* Revert "cancel fuzz"

This reverts commit 7de5615aa73c26cf33f2e064e7501718fb1f1104.

* todo

* first pass

* second pass

* touchup inculdes

* drop C from bench

* no fixed import

* all use full imports

* tidy up cmakelists

* alternative handling of cancel at join

* further refine cancel path

* tmp

* not all threads

* don't use internal

* complexity

* Revert "cancel test"

This reverts commit 30db539.

* structure for stop.cxx

* stop.cxx

* use stop.cxx

* better op names

* todo

* cancel tests

* root package propagates exception

* stop plumbed

* fix infinite loop

* access the stop source of the reciver

* todo

* allow early cancellation of root

* tmp cancel

* co_await scope()

* no export stop source

* explicitly default initialize

* basic cancel test

* busy versions

* tests

* TMP no bind

* clean ups

* cancel notes

* Revert "TMP no bind"

This reverts commit 3b9bd7a.

* move external to benchmark

* stop token

* use stop token

* split ops

* markdown (delete before merge)

* fix promise

* fix tests

* reciever changes

* todo

* use scoped join

* format

* rename 1

* rename 2

* rename 3

* rename 4

* rename 5

* rm dead file

* rename 6

* rename 7

* rename 8

* restore comment

* nicer name

* complexity notes

* more tests

* dynamic section

* rename

* gaurd max

* update comments

* drop branch

* drop template

Author: ConorWilliams

.codespellrc

@@ -1,5 +1,5 @@
 [codespell]
-builtin = clear,rare,en-GB_to_en-US,names,informal,code
+builtin = clear,rare,names,informal,code
 check-filenames =
 check-hidden =
 ignore-words-list = deque,warmup,stdio,copyable,combinate

AGENTS.md

@@ -103,34 +103,6 @@ All tests should pass. If tests fail, check that:
 - Build completed without errors
 - Any changes you have made are correct
 
-## Linting & Validation
-
-The CI runs two linting tools that you should run before committing:
-
-### codespell (spelling)
-
-```bash
-codespell
-```
-
-Config: `.codespellrc` (ignores: build/, .git/, etc.)
-Should produce no output if passing.
-
-### clang-format (code formatting)
-
-```bash
-find src include test benchmark/src -name "*.cpp" -o -name "*.hpp" -o -name "*.cxx" | xargs clang-format --dry-run --Werror
-```
-
-Config: `.clang-format` (110 column limit, specific style)
-Should produce no output if passing.
-
-**To auto-fix formatting**:
-
-```bash
-find src include test benchmark/src -name "*.cpp" -o -name "*.hpp" -o -name "*.cxx" | xargs clang-format -i
-```
-
 ## Project Structure
 
 ### Source Layout
@@ -150,10 +122,9 @@ libfork/
 │   ├── batteries/            # libfork.batteries — stacks, contexts, adaptors
 │   │   ├── batteries.cxx     #   aggregator
 │   │   └── *.cxx             #   :partitions
-│   ├── schedulers/           # libfork.schedulers — concrete schedulers
+│   └── schedulers/           # libfork.schedulers — concrete schedulers
 │   │   ├── schedulers.cxx    #   aggregator
 │   │   └── *.cxx             #   :partitions
-│   └── exception.cpp         # terminate_with() implementation
 ├── test/src/**/              # Test suite (Catch2) — uses `import libfork;`
 │   └── *.cpp
 ├── benchmark/src/            # Benchmarking suite (google-benchmark)
@@ -189,7 +160,6 @@ All workflows follow this pattern:
 1. **Modify source files** in `src/`, `include/`, `test/`, or `benchmark/`
 2. **Rebuild**: `cmake --build --preset <your-preset>`
 3. **Test**: `ctest --preset <your-preset>`
-4. **Lint**: Run codespell and clang-format checks
 
 #### Adding/removing files from `src/` or `include/`
 
@@ -230,11 +200,3 @@ rm -rf build/
 
 **Problem**: "Could not automatically find libc++.modules.json"
 **Solution**: Ensure LLVM is installed via Homebrew; toolchain auto-detects the path
-
-### Linting Failures
-
-**Problem**: clang-format errors
-**Solution**: Run fix command above to auto-format code
-
-**Problem**: codespell errors
-**Solution**: Fix typos or add to ignore list in `.codespellrc` if false positive

CMakeLists.txt

@@ -31,7 +31,7 @@ set(CMAKE_CXX_MODULE_STD 1)
 add_library(libfork_libfork)
 add_library(libfork::libfork ALIAS libfork_libfork)
 
-# target_link_libraries(libfork_libfork PRIVATE Threads::Threads)
+target_link_libraries(libfork_libfork PUBLIC Threads::Threads)
 
 set_property(TARGET libfork_libfork PROPERTY EXPORT_NAME libfork)
 
@@ -84,6 +84,7 @@ target_sources(libfork_libfork
       src/core/execute.cxx
       src/core/receiver.cxx
       src/core/promise.cxx
+      src/core/stop.cxx
       # libfork.batteries
       src/batteries/batteries.cxx
       src/batteries/deque.cxx

benchmark/CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 4.2.1 FATAL_ERROR)
 
-project(libfork_benchmark LANGUAGES C CXX)
+project(libfork_benchmark LANGUAGES CXX)
 
 if(NOT CMAKE_BUILD_TYPE STREQUAL "Release")
   message(WARNING "It is recommended to build benchmarks in Release mode for accurate results.")
@@ -17,7 +17,8 @@ target_link_libraries(libfork_benchmark
     benchmark::benchmark_main
 )
 
-# Common headers
+# Common components
+
 target_sources(libfork_benchmark
   PRIVATE
     FILE_SET HEADERS FILES
@@ -28,18 +29,13 @@ target_sources(libfork_benchmark
       src
 )
 
-# Common sources
 target_sources(libfork_benchmark
   PRIVATE
     src/libfork_benchmark/uts/uts.cpp
 )
 
-
 # C lib for UTS
-add_library(uts_c OBJECT
-  src/libfork_benchmark/uts/external/uts.c
-  src/libfork_benchmark/uts/external/rng/brg_sha1.c
-)
+add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/external/uts external/uts)
 
 target_link_libraries(libfork_benchmark PRIVATE uts_c)
 

benchmark/external/uts/CMakeLists.txt

@@ -0,0 +1,19 @@
+cmake_minimum_required(VERSION 4.2.1 FATAL_ERROR)
+
+project(uts_external LANGUAGES C)
+
+add_library(uts_c)
+
+target_sources(uts_c
+  PRIVATE
+    src/uts.c
+    src/rng/brg_sha1.c
+  PUBLIC
+    FILE_SET HEADERS
+    BASE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/include
+    FILES
+      include/uts/uts.h
+      include/uts/rng/rng.h
+      include/uts/rng/brg_sha1.h
+      include/uts/rng/brg_types.h
+)

…rk_benchmark/uts/external/rng/brg_sha1.h …/external/uts/include/uts/rng/brg_sha1.hbenchmark/src/libfork_benchmark/uts/external/rng/brg_sha1.h renamed to benchmark/external/uts/include/uts/rng/brg_sha1.h benchmark/src/libfork_benchmark/uts/external/rng/brg_sha1.h renamed to benchmark/external/uts/include/uts/rng/brg_sha1.h

@@ -33,7 +33,7 @@
 #ifndef _SHA1_H
 #define _SHA1_H
 
-#include "brg_types.h"
+#include "uts/rng/brg_types.h"
 
 #define SHA1_BLOCK_SIZE 64
 #define SHA1_DIGEST_SIZE 20

…k_benchmark/uts/external/rng/brg_types.h …external/uts/include/uts/rng/brg_types.hbenchmark/src/libfork_benchmark/uts/external/rng/brg_types.h renamed to benchmark/external/uts/include/uts/rng/brg_types.h benchmark/src/libfork_benchmark/uts/external/rng/brg_types.h renamed to benchmark/external/uts/include/uts/rng/brg_types.h

@@ -1,6 +1,6 @@
 #ifndef _RNG_H
 #define _RNG_H
 
-#include "brg_sha1.h"
+#include "uts/rng/brg_sha1.h"
 
 #endif /* _RNG_H */

…libfork_benchmark/uts/external/rng/rng.h …hmark/external/uts/include/uts/rng/rng.hbenchmark/src/libfork_benchmark/uts/external/rng/rng.h renamed to benchmark/external/uts/include/uts/rng/rng.h benchmark/src/libfork_benchmark/uts/external/rng/rng.h renamed to benchmark/external/uts/include/uts/rng/rng.h

@@ -22,7 +22,7 @@
 extern "C" {
   #endif
 
-  #include "rng/rng.h"
+  #include "uts/rng/rng.h"
 
   #define UTS_VERSION "2.1"