Skip to content

Commit d98ee9e

Browse files
authored
Merge pull request nextcloud#705 from nextcloud/unknown-notification
fix: fix noticition deprecation warning
2 parents 3768c8e + fac2251 commit d98ee9e

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

appinfo/info.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<description><![CDATA[Push update support for desktop app.
1212
1313
Once the app is installed, the push binary needs to be setup. You can either use the setup wizard with `occ notify_push:setup` or see the [README](http://github.com/nextcloud/notify_push) for detailed setup instructions]]></description>
14-
<version>1.3.2</version>
14+
<version>1.3.3</version>
1515
<licence>agpl</licence>
1616
<author>Robin Appelman</author>
1717
<namespace>NotifyPush</namespace>
@@ -27,7 +27,7 @@ Once the app is installed, the push binary needs to be setup. You can either use
2727
<bugs>https://github.com/nextcloud/notify_push/issues</bugs>
2828

2929
<dependencies>
30-
<nextcloud min-version="29" max-version="34"/>
30+
<nextcloud min-version="30" max-version="34"/>
3131
</dependencies>
3232

3333
<repair-steps>

lib/Listener.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
use OCP\Notification\IDismissableNotifier;
2323
use OCP\Notification\INotification;
2424
use OCP\Notification\INotifier;
25+
use OCP\Notification\UnknownNotificationException;
2526
use OCP\Share\Events\ShareCreatedEvent;
2627
use OCP\Share\IShare;
2728

@@ -102,7 +103,7 @@ public function getName(): string {
102103
}
103104

104105
public function prepare(INotification $notification, string $languageCode): INotification {
105-
throw new \InvalidArgumentException();
106+
throw new UnknownNotificationException();
106107
}
107108

108109
public function dismissNotification(INotification $notification): void {

psalm.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xmlns="https://getpsalm.org/schema/config"
1010
xsi:schemaLocation="https://getpsalm.org/schema/config https://getpsalm.org/schema/config"
11-
phpVersion="8.0"
11+
phpVersion="8.1"
1212
>
1313
<projectFiles>
1414
<directory name="lib"/>

0 commit comments

Comments
 (0)