Skip to content

Commit e5d871a

Browse files
test(personalities): update canonical-pool set for 15-roster (post #185) (#191)
Sibling fix to PR #185: test_personality_prompt_schema's canonical set was updated when Aristotle + Socrates rotated out in favor of 7 new figures, but test_web_data_personalities_block's identical canonical set was missed. The test failed against main with: AssertionError: missing v1 personas from emitted block: ['aristotle', 'socrates'] Same fix pattern as #185: update the canonical set to the current 15 (8 retained + 7 added). 7/7 tests in the file pass. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d367e19 commit e5d871a

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

tests/unit/test_web_data_personalities_block.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,26 @@ def test_malformed_file_skipped(tmp_path: Path) -> None:
8484

8585

8686
def test_live_pool_emits_expected_count(tmp_path: Path) -> None:
87-
"""Integration smoke: run against the actual repo pool (the v1 ten)."""
87+
"""Integration smoke: run against the actual repo pool.
88+
89+
Roster as of 2026-05-16: 15 personas (Aristotle and Socrates were
90+
rotated out in PR #185 in favor of 7 modern scientific figures;
91+
see notes in test_personality_prompt_schema.py for the rationale)."""
8892
repo = Path(__file__).resolve().parents[2]
8993
pool_dir = repo / "agents" / "prompts" / "personalities"
9094
if not pool_dir.is_dir():
9195
pytest.skip("live pool not present")
9296
block = _build_personalities_block(repo)
9397
slugs = {e["slug"] for e in block}
9498
canonical = {
95-
"ada-lovelace", "aristotle", "dan-rockmore", "daniel-kahneman",
99+
# v1 retained
100+
"ada-lovelace", "dan-rockmore", "daniel-kahneman",
96101
"david-krakauer", "geoffrey-west", "john-von-neumann",
97-
"marie-curie", "rosalind-franklin", "socrates",
102+
"marie-curie", "rosalind-franklin",
103+
# 2026-05-16 additions — replacing aristotle/socrates
104+
"alan-turing", "albert-einstein", "eric-kandel",
105+
"freeman-dyson", "linus-pauling", "richard-feynman",
106+
"stephen-wolfram",
98107
}
99108
missing = canonical - slugs
100-
assert not missing, f"missing v1 personas from emitted block: {sorted(missing)}"
109+
assert not missing, f"missing canonical personas from emitted block: {sorted(missing)}"

0 commit comments

Comments
 (0)