test(personalities): update canonical-pool set for 15-roster (sibling fix to #185)#191
Merged
Merged
Conversation
Sibling fix to PR #185: test_personality_prompt_schema's canonical set was updated when Aristotle + Socrates rotated out in favor of 7 new figures, but test_web_data_personalities_block's identical canonical set was missed. The test failed against main with: AssertionError: missing v1 personas from emitted block: ['aristotle', 'socrates'] Same fix pattern as #185: update the canonical set to the current 15 (8 retained + 7 added). 7/7 tests in the file pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sibling fix to #185 — test_personality_prompt_schema's canonical set was updated when Aristotle + Socrates rotated out, but test_web_data_personalities_block was missed. Same fix pattern. 7/7 tests pass.
🤖 Generated with Claude Code