Skip to content

test(personalities): update canonical-pool set for 15-roster (sibling fix to #185) #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremymanning merged 1 commit into from
May 17, 2026
Merged

test(personalities): update canonical-pool set for 15-roster (sibling fix to #185) #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/unit/test_web_data_personalities_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,17 +84,26 @@ def test_malformed_file_skipped(tmp_path: Path) -> None:


def test_live_pool_emits_expected_count(tmp_path: Path) -> None:
"""Integration smoke: run against the actual repo pool (the v1 ten)."""
"""Integration smoke: run against the actual repo pool.

Roster as of 2026-05-16: 15 personas (Aristotle and Socrates were
rotated out in PR #185 in favor of 7 modern scientific figures;
see notes in test_personality_prompt_schema.py for the rationale)."""
repo = Path(__file__).resolve().parents[2]
pool_dir = repo / "agents" / "prompts" / "personalities"
if not pool_dir.is_dir():
pytest.skip("live pool not present")
block = _build_personalities_block(repo)
slugs = {e["slug"] for e in block}
canonical = {
"ada-lovelace", "aristotle", "dan-rockmore", "daniel-kahneman",
# v1 retained
"ada-lovelace", "dan-rockmore", "daniel-kahneman",
"david-krakauer", "geoffrey-west", "john-von-neumann",
"marie-curie", "rosalind-franklin", "socrates",
"marie-curie", "rosalind-franklin",
# 2026-05-16 additions — replacing aristotle/socrates
"alan-turing", "albert-einstein", "eric-kandel",
"freeman-dyson", "linus-pauling", "richard-feynman",
"stephen-wolfram",
}
missing = canonical - slugs
assert not missing, f"missing v1 personas from emitted block: {sorted(missing)}"
assert not missing, f"missing canonical personas from emitted block: {sorted(missing)}"
Loading