Skip to content

fix: address file browser bonus issues #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradeeban merged 2 commits into from
Mar 23, 2026
Merged

fix: address file browser bonus issues #369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906626b
fix: address file browser bonus issues
avinxshKD Mar 21, 2026
5abb159
chore: parameterize file-size limit and document config
avinxshKD Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/component/fileBrowser.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ const LocalFileBrowser = ({ superState, dispatcher }) => {
const [dirButton, setDirButton] = useState(false);
const [fileState, setFileState] = useState([]);

const getLocalFileState = (state) => state.map((file) => ({
key: file.key,
modified: file.modified,
size: file.size,
fileName: file.fileObj ? file.fileObj.name : null,
}));

useEffect(() => {
if ('showDirectoryPicker' in window) {
setDirButton(true);
Expand All @@ -35,7 +42,7 @@ const LocalFileBrowser = ({ superState, dispatcher }) => {
// setFileState({ files: allFiles });
// }
try {
window.localStorage.setItem('fileList', JSON.stringify(fileState));
window.localStorage.setItem('fileList', JSON.stringify(getLocalFileState(fileState)));
} catch (e) {
toast.error(e.message);
}
Expand All @@ -47,13 +54,14 @@ const LocalFileBrowser = ({ superState, dispatcher }) => {

const handleSelectFile = (data) => {
const fileExtensions = ['jpeg', 'jpg', 'png', 'exe'];
if (fileExtensions.includes(data.fileObj.name.split('.').pop())) {
const fileExt = data.fileObj.name.split('.').pop().toLowerCase();
if (fileExtensions.includes(fileExt)) {
// eslint-disable-next-line no-alert
alert('Wrong file extension');
return;
}

if (data.fileObj.name.split('.').pop() === 'graphml') {
if (fileExt === 'graphml') {
let foundi = -1;
superState.graphs.forEach((g, i) => {
if ((g.fileName === data.fileObj.name)) {
Expand Down Expand Up @@ -251,7 +259,7 @@ const LocalFileBrowser = ({ superState, dispatcher }) => {

setFileState(filesArray);
try {
window.localStorage.setItem('fileList', JSON.stringify(filesArray));
window.localStorage.setItem('fileList', JSON.stringify(getLocalFileState(filesArray)));
} catch (e) {
toast.error(e.message);
}
Expand Down
9 changes: 9 additions & 0 deletions src/toolbarActions/toolbarFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import parser from '../graph-builder/graphml/parser';
import { actionType as T } from '../reducer';

const getGraphFun = (superState) => superState.curGraphInstance;
const MAX_FILE_SIZE = 10 * 1024 * 1024;
Comment thread
avinxshKD marked this conversation as resolved.
Outdated

const createNode = (state, setState) => {
setState({
Expand Down Expand Up @@ -106,6 +107,10 @@ async function saveGraphMLFile(state) {

const readFile = async (state, setState, file, fileHandle) => {
if (file) {
if (file.size > MAX_FILE_SIZE) {
toast.error('File size exceeds 10MB');
return;
}
const fr = new FileReader();
const projectName = file.name;
if (file.name.split('.').pop() === 'graphml') {
Expand All @@ -127,6 +132,10 @@ const readFile = async (state, setState, file, fileHandle) => {

const readTextFile = (state, setState, file, fileHandle) => {
if (file) {
if (file.size > MAX_FILE_SIZE) {
toast.error('File size exceeds 10MB');
return;
}
setState({
type: T.EDIT_TEXTFILE,
payload: { show: true, fileObj: file, fileHandle },
Expand Down