Skip to content

Commit 16e2a50

Browse files
authored
Merge pull request #416 from GaneshPatil7517/refactor/pidsig-use-tryparam
refactor: simplify parameter handling in pidsig.py using concore.tryparam() (fixes #365)
2 parents 2cd0f08 + 84aeaba commit 16e2a50

1 file changed

Lines changed: 7 additions & 28 deletions

File tree

tools/pidsig.py

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -7,34 +7,13 @@
77
Prev_Error = 0
88
I = 0
99

10-
try:
11-
sp = concore.params['sp']
12-
except:
13-
sp = 67.5
14-
try:
15-
Kp = concore.params['Kp']
16-
except:
17-
Kp = 0.1
18-
try:
19-
Ki = concore.params['Ki']
20-
except:
21-
Ki = 0.01
22-
try:
23-
Kd = concore.params['Kd']
24-
except:
25-
Kd = 0.03
26-
try:
27-
freq = concore.params['freq']
28-
except:
29-
freq = 30
30-
try:
31-
sigout = concore.params['sigout']
32-
except:
33-
sigout = True
34-
try:
35-
cin = concore.params['cin']
36-
except:
37-
cin = 'hr'
10+
sp = concore.tryparam('sp', 67.5)
11+
Kp = concore.tryparam('Kp', 0.1)
12+
Ki = concore.tryparam('Ki', 0.01)
13+
Kd = concore.tryparam('Kd', 0.03)
14+
freq = concore.tryparam('freq', 30)
15+
sigout = concore.tryparam('sigout', True)
16+
cin = concore.tryparam('cin', 'hr')
3817

3918
def pid_controller(ym):
4019
global Prev_Error, I, freq

0 commit comments

Comments
 (0)