refactor: remove duplicate Docker import logic, prevent Windows batch generation in Docker, and fix file descriptor leaks (fixes #285)

Author: GaneshPatil7517

import_concore.m

@@ -1,42 +1,63 @@
-function import_concore
-    global concore;
-
-    try
-      pid = getpid();
-    catch exc
-      pid = feature('getpid');
-    end
-    outputpid = fopen('concorekill.bat','w');
-    fprintf(outputpid,'%s',['taskkill /F /PID ',num2str(pid)]);
-    fclose(outputpid);
-   
-  
-    try
-      iportfile = fopen('concore.iport');
-      concore.iports = fscanf(iportfile,'%c');
-    catch exc
-      iportfile = '';
-    end
-
-    try
-      oportfile = fopen('concore.oport');
-      concore.oports = fscanf(oportfile,'%c');
-    catch exc
-      oportfile = '';
-    end
-
-    concore.s = '';
-    concore.olds = '';
-    concore.delay = 1;
-    concore.retrycount = 0;
-    if exist('/in1','dir')==7  % 5/20/21  work for docker or local
-        concore.inpath = '/in';
-        concore.outpath = '/out';
-    else
-        concore.inpath = 'in';
-        concore.outpath = 'out';
-    end
-    concore.simtime = 0;
-
-    concore_default_maxtime(100);
-end
+function import_concore
+    global concore;
+
+    if ispc
+        try
+          pid = getpid();
+        catch exc
+          pid = feature('getpid');
+        end
+        outputpid = fopen('concorekill.bat','w');
+        if outputpid ~= -1
+            fprintf(outputpid,'%s',['taskkill /F /PID ',num2str(pid)]);
+            fclose(outputpid);
+        else
+            warning('import_concore:ConcoreKillFileOpenFailed', ...
+                'Could not create concorekill.bat. Continuing without kill script.');
+        end
+    end
+   
+  
+    try
+      iportfile = fopen('concore.iport');
+      concore.iports = fscanf(iportfile,'%c');
+      if isnumeric(iportfile) && iportfile ~= -1
+          fclose(iportfile);
+      end
+      iportfile = -1;
+    catch exc
+      if exist('iportfile', 'var') && isnumeric(iportfile) && iportfile ~= -1
+          fclose(iportfile);
+      end
+      iportfile = -1;
+    end
+
+    try
+      oportfile = fopen('concore.oport');
+      concore.oports = fscanf(oportfile,'%c');
+      if isnumeric(oportfile) && oportfile ~= -1
+          fclose(oportfile);
+      end
+      oportfile = -1;
+    catch exc
+      if exist('oportfile', 'var') && isnumeric(oportfile) && oportfile ~= -1
+          fclose(oportfile);
+      end
+      oportfile = -1;
+    end
+
+    concore.s = '';
+    concore.olds = '';
+    concore.delay = 1;
+    concore.retrycount = 0;
+    if exist('/in1','dir')==7  % 5/20/21  work for docker or local
+        concore.inpath = '/in';
+        concore.outpath = '/out';
+    else
+        concore.inpath = 'in';
+        concore.outpath = 'out';
+    end
+    concore.simtime = 0;
+
+    concore_default_maxtime(100);
+end

import_concoredocker.m

@@ -1,42 +1,45 @@
-function import_concore
-    global concore;
-
-    try
-      pid = getpid();
-    catch exc
-      pid = feature('getpid');
-    end
-    outputpid = fopen('concorekill.bat','w');
-    fprintf(outputpid,'%s',['taskkill /F /PID ',num2str(pid)]);
-    fclose(outputpid);
-   
-  
-    try
-      iportfile = fopen('concore.iport');
-      concore.iports = fscanf(iportfile,'%c');
-    catch exc
-      iportfile = '';
-    end
-
-    try
-      oportfile = fopen('concore.oport');
-      concore.oports = fscanf(oportfile,'%c');
-    catch exc
-      oportfile = '';
-    end
-
-    concore.s = '';
-    concore.olds = '';
-    concore.delay = 1;
-    concore.retrycount = 0;
-    if exist('/in1','dir')==7  % 5/20/21  work for docker or local
-        concore.inpath = '/in';
-        concore.outpath = '/out';
-    else
-        concore.inpath = 'in';
-        concore.outpath = 'out';
-    end
-    concore.simtime = 0;
-
-    concore_default_maxtime(100);
-end
+function import_concore
+    global concore;
+
+    % Docker/Linux environment — no Windows batch file generation
+   
+  
+    iportfile = fopen('concore.iport');
+    if iportfile ~= -1
+        try
+            concore.iports = fscanf(iportfile,'%c');
+        catch exc
+            concore.iports = '';
+        end
+        fclose(iportfile);
+    else
+        concore.iports = '';
+    end
+
+    oportfile = fopen('concore.oport');
+    if oportfile ~= -1
+        try
+            concore.oports = fscanf(oportfile,'%c');
+        catch exc
+            concore.oports = '';
+        end
+        fclose(oportfile);
+    else
+        concore.oports = '';
+    end
+
+    concore.s = '';
+    concore.olds = '';
+    concore.delay = 1;
+    concore.retrycount = 0;
+    if exist('/in1','dir')==7  % 5/20/21  work for docker or local
+        concore.inpath = '/in';
+        concore.outpath = '/out';
+    else
+        concore.inpath = 'in';
+        concore.outpath = 'out';
+    end
+    concore.simtime = 0;
+
+    concore_default_maxtime(100);
+end