Address Copilot review feedback

- Add explicit validation for port 0 (invalid)
- Enforce directory-only input for --source option
- Use warnings parameter in _check_source_files for clarity
- Add test coverage for port 0 and port > 65535 edge cases
- Reorder port validation to check range before conflicts

Author: Sahil-u07

concore_cli/cli.py

@@ -47,7 +47,12 @@ def run(workflow_file, source, output, type, auto_build):
 
 @cli.command()
 @click.argument('workflow_file', type=click.Path(exists=True))
-@click.option('--source', '-s', type=click.Path(exists=True), help='Source directory to check file references')
+@click.option(
+    '--source',
+    '-s',
+    type=click.Path(exists=True, file_okay=False, dir_okay=True, path_type=Path),
+    help='Source directory to check file references',
+)
 def validate(workflow_file, source):
     """Validate a workflow file"""
     try:

concore_cli/commands/validate.py

@@ -161,10 +161,12 @@ def _check_source_files(soup, source_path, errors, warnings):
 
         label = label_tag.text.strip()
         if ':' not in label:
+            warnings.append(f"Skipping node with invalid label format (expected 'ID:filename')")
             continue
 
         parts = label.split(':')
         if len(parts) != 2:
+            warnings.append(f"Skipping node '{label}' with invalid format")
             continue
 
         _, filename = parts
@@ -230,6 +232,13 @@ def _check_zmq_ports(soup, errors, warnings):
         port_name = match.group(2)
         port_num = int(port_hex, 16)
 
+        if port_num < 1:
+            errors.append(f"Invalid port number: {port_num} (0x{port_hex}) must be at least 1")
+            continue
+        elif port_num > 65535:
+            errors.append(f"Invalid port number: {port_num} (0x{port_hex}) exceeds maximum (65535)")
+            continue
+        
         if port_num in ports_used:
             existing_name = ports_used[port_num]
             if existing_name != port_name:
@@ -239,8 +248,6 @@ def _check_zmq_ports(soup, errors, warnings):
 
         if port_num < 1024:
             warnings.append(f"Port {port_num} (0x{port_hex}) is in reserved range (< 1024)")
-        elif port_num > 65535:
-            errors.append(f"Invalid port number: {port_num} (0x{port_hex}) exceeds maximum (65535)")
 
 def show_results(console, errors, warnings, info):
     if errors:

tests/test_graph.py

@@ -241,6 +241,52 @@ def test_validate_cycle_detection(self):
 
         self.assertIn('cycles', result.output)
         self.assertIn('control loops', result.output)
+    
+    def test_validate_port_zero(self):
+        content = '''
+        <graphml xmlns:y="http://www.yworks.com/xml/graphml">
+            <graph id="G" edgedefault="directed">
+                <node id="n0">
+                    <data key="d0"><y:NodeLabel>n0:script1.py</y:NodeLabel></data>
+                </node>
+                <node id="n1">
+                    <data key="d0"><y:NodeLabel>n1:script2.py</y:NodeLabel></data>
+                </node>
+                <edge source="n0" target="n1">
+                    <data key="d1"><y:EdgeLabel>0x0_invalid</y:EdgeLabel></data>
+                </edge>
+            </graph>
+        </graphml>
+        '''
+        filepath = self.create_graph_file('port_zero.graphml', content)
+        
+        result = self.runner.invoke(cli, ['validate', filepath])
+        
+        self.assertIn('Validation failed', result.output)
+        self.assertIn('must be at least 1', result.output)
+    
+    def test_validate_port_exceeds_maximum(self):
+        content = '''
+        <graphml xmlns:y="http://www.yworks.com/xml/graphml">
+            <graph id="G" edgedefault="directed">
+                <node id="n0">
+                    <data key="d0"><y:NodeLabel>n0:script1.py</y:NodeLabel></data>
+                </node>
+                <node id="n1">
+                    <data key="d0"><y:NodeLabel>n1:script2.py</y:NodeLabel></data>
+                </node>
+                <edge source="n0" target="n1">
+                    <data key="d1"><y:EdgeLabel>0x10000_toobig</y:EdgeLabel></data>
+                </edge>
+            </graph>
+        </graphml>
+        '''
+        filepath = self.create_graph_file('port_max.graphml', content)
+        
+        result = self.runner.invoke(cli, ['validate', filepath])
+        
+        self.assertIn('Validation failed', result.output)
+        self.assertIn('exceeds maximum (65535)', result.output)
 
 if __name__ == '__main__':
     unittest.main()