refactor: address remaining Copilot review suggestions

GaneshPatil7517 · GaneshPatil7517 · commit 58915e36f0fc · 2026-02-14T12:03:31.000+05:30
- Remove duplicate concore.delay assignments (12 files)
- Remove self-assignment no-ops: concore.inpath/outpath = concore.inpath/outpath (9 files)
- Use float(concore.simtime) snapshot for old2/old_concore_simtime variables (7 files)
diff --git a/0mq/comm_node.py b/0mq/comm_node.py
@@ -1,6 +1,5 @@
 import concore
 
-concore.delay = 0.07
 concore.delay = 0.07
 concore.simtime = 0
 concore.default_maxtime(100)
diff --git a/0mq/funbody.py b/0mq/funbody.py
@@ -49,7 +49,7 @@
         u = u[1:] 
         concore.write(concore.oport['U2'],"u",u)
         print(u)
-        old2 = concore.simtime
+        old2 = float(concore.simtime)
         while concore.unchanged() or concore.simtime <= old2:
             ym = concore.read(concore.iport['Y2'],"ym",init_simtime_ym)
         ym = [concore.simtime]+ym
diff --git a/0mq/funbody2.py b/0mq/funbody2.py
@@ -25,7 +25,6 @@
 
 paired_transmitter.start_background_sync()
 
-concore.delay = 0.07
 concore.delay = 0.07
 concore.simtime = 0
 concore.default_maxtime(100)
diff --git a/0mq/funbody_distributed.py b/0mq/funbody_distributed.py
@@ -15,7 +15,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07         
-concore.delay = 0.07        
 concore.simtime = 0         
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
@@ -47,7 +46,7 @@
     if 'U2' in concore.oport: 
         concore.write(concore.oport['U2'], "u", u_data_values)
 
-    old_concore_simtime = concore.simtime
+    old_concore_simtime = float(concore.simtime)
     while concore.unchanged() or concore.simtime <= old_concore_simtime:
         # Assuming concore.iport['Y2'] is a file port (e.g., from pmpymax.py)
         ym_data_values = concore.read(concore.iport['Y2'], "ym", init_simtime_ym_str)
diff --git a/0mq/funbody_zmq.py b/0mq/funbody_zmq.py
@@ -14,8 +14,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07         
-concore.delay = 0.07        
-concore.inpath = concore.inpath
 concore.simtime = 0         
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
diff --git a/0mq/funbody_zmq2.py b/0mq/funbody_zmq2.py
@@ -14,8 +14,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07         
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0         
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
@@ -47,7 +45,7 @@
     if 'U2' in concore.oport: 
         concore.write(concore.oport['U2'], "u", u_data_values)
 
-    old_concore_simtime = concore.simtime
+    old_concore_simtime = float(concore.simtime)
     while concore.unchanged() or concore.simtime <= old_concore_simtime:
         # Assuming concore.iport['Y2'] is a file port (e.g., from pmpymax.py)
         ym_data_values = concore.read(concore.iport['Y2'], "ym", init_simtime_ym_str)
diff --git a/0mq/funcall.py b/0mq/funcall.py
@@ -3,9 +3,6 @@
 print("funcall 0mq")
 
 concore.delay = 0.07
-concore.delay = 0.07
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 concore.default_maxtime(100)
 init_simtime_u = "[0.0, 0.0, 0.0]"
diff --git a/0mq/funcall_distributed.py b/0mq/funcall_distributed.py
@@ -14,7 +14,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07        
-concore.delay = 0.07       
 concore.simtime = 0
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
diff --git a/0mq/funcall_zmq.py b/0mq/funcall_zmq.py
@@ -14,9 +14,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07        
-concore.delay = 0.07       
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
diff --git a/measurements/Latency/funbody_distributed.py b/measurements/Latency/funbody_distributed.py
@@ -15,9 +15,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07         
-concore.delay = 0.07        
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0         
 concore.default_maxtime(100) 
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
@@ -49,7 +46,7 @@
     if 'U2' in concore.oport: 
         concore.write(concore.oport['U2'], "u", u_data_values)
 
-    old_concore_simtime = concore.simtime
+    old_concore_simtime = float(concore.simtime)
     while concore.unchanged() or concore.simtime <= old_concore_simtime:
         # Assuming concore.iport['Y2'] is a file port (e.g., from pmpymax.py)
         ym_data_values = concore.read(concore.iport['Y2'], "ym", init_simtime_ym_str)
diff --git a/measurements/Latency/funcall_distributed.py b/measurements/Latency/funcall_distributed.py
@@ -15,7 +15,6 @@
 
 # Standard concore initializations
 concore.delay = 0.07
-concore.delay = 0.07
 concore.simtime = 0
 concore.default_maxtime(100) # Recommend increasing this for more data points, e.g., 1000
 init_simtime_u_str = "[0.0, 0.0, 0.0]"
diff --git a/measurements/comm_node_test.py b/measurements/comm_node_test.py
@@ -4,8 +4,6 @@
 
 # --- Script Configuration ---
 concore.delay = 0.07
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 concore.default_maxtime(100) # This will be ignored by the new logic
 init_simtime_u = "[0.0, 0.0, 0.0]"
@@ -41,7 +39,7 @@
         break
 
     # 3. Wait for a message from the 'Y1' channel
-    old2 = concore.simtime
+    old2 = float(concore.simtime)
     while concore.unchanged() or concore.simtime <= old2:
         ym = concore.read(concore.iport['Y1'], "ym", init_simtime_ym)
         
diff --git a/nintan/powermetermax.py b/nintan/powermetermax.py
@@ -4,9 +4,6 @@
 print("powermeter")
 
 concore.delay = 0.07
-concore.delay = 0.07
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 #Nsim = 100
 concore.default_maxtime(100)
diff --git a/testsou/funbody.py b/testsou/funbody.py
@@ -2,8 +2,6 @@
 print("funbody")
 
 concore.delay = 0.07
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 concore.default_maxtime(100)
 init_simtime_u = "[0.0, 0.0, 0.0]"
@@ -16,7 +14,7 @@
         u = concore.read(concore.iport['U1'],"u",init_simtime_u)
     concore.write(concore.oport['U2'],"u",u)
     print(u)
-    old2 = concore.simtime
+    old2 = float(concore.simtime)
     while concore.unchanged() or concore.simtime <= old2:
         ym = concore.read(concore.iport['Y2'],"ym",init_simtime_ym)
     concore.write(concore.oport['Y1'],"ym",ym)
diff --git a/testsou/funcall.py b/testsou/funcall.py
@@ -1,7 +1,6 @@
 import concore
 print("funcall")
 
-concore.delay = 0.07
 concore.delay = 0.07
 concore.simtime = 0
 concore.default_maxtime(100)
@@ -15,7 +14,7 @@
         u = concore.read(concore.iport['U'],"u",init_simtime_u)
     concore.write(concore.oport['U1'],"u",u)
     print(u)
-    old2 = concore.simtime
+    old2 = float(concore.simtime)
     while concore.unchanged() and concore.simtime <= old2:
         ym = concore.read(concore.iport['Y1'],"ym",init_simtime_ym)
     concore.write(concore.oport['Y'],"ym",ym)
diff --git a/testsou/mix.py b/testsou/mix.py
@@ -3,9 +3,6 @@
 import time
 
 concore.delay = 0.005
-concore.delay = 0.005
-concore.inpath = concore.inpath
-concore.outpath = concore.outpath
 concore.simtime = 0
 concore.default_maxtime(150)
 init_simtime_u = "[0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]"
