Merge pull request #426 from avinxshKD/fix/duplicate-node-label-v2

fix: error on duplicate node labels in mkconcore and validate

Author: pradeeban

concore_cli/commands/validate.py

@@ -117,7 +117,14 @@ def finalize():
                     warnings.append(f"Node {node_id} has no label")
             except Exception as e:
                 warnings.append(f"Error parsing node: {str(e)}")
-        
+
+        # duplicate labels cause silent corruption in mkconcore.py
+        seen = set()
+        for label in node_labels:
+            if label in seen:
+                errors.append(f"Duplicate node label: '{label}'")
+            seen.add(label)
+
         node_ids = {node.get('id') for node in nodes if node.get('id')}
         for edge in edges:
             source = edge.get('source')

mkconcore.py

@@ -309,6 +309,12 @@ def cleanup_script_files():
     except (IndexError, AttributeError):
         logging.debug('A node with no valid properties encountered and ignored')
 
+label_values = list(nodes_dict.values())
+duplicates = {label for label in label_values if label_values.count(label) > 1}
+if duplicates:
+    logging.error(f"Duplicate node labels found: {sorted(duplicates)}")
+    quit()
+
 for edge in edges_text:
     try:
         data = edge.find('data', recursive=False)