Skip to content

issue #31 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parteekcoder wants to merge 5 commits into from
Closed

issue #31 #32

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e928cc
issue #31
parteekcoder Feb 18, 2023
1b2d536
Merge branch 'ControlCore-Project:dev' into dev
parteekcoder Feb 18, 2023
5e0f3d8
Update main.py
parteekcoder Feb 18, 2023
9201458
Merge branch 'ControlCore-Project:dev' into dev
parteekcoder Feb 18, 2023
b154a0d
Merge branch 'dev' of https://github.com/parteekcoder/concore into dev
parteekcoder Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fri/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ $ pip install jupyterlab

To run the FRI as a server:
````
$ cd conore
$ cd conore/fri

@pradeeban pradeeban Feb 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was an issue in the dev branch. It was updated in the main branch. Now I have merged the pull request. So this README should be fixed now.


$ git checkout dev

Expand Down
7 changes: 5 additions & 2 deletions fri/server/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,17 @@ def build(dir):
makestudy_dir = dirname + "/" + graphml_file #for makestudy
dir_path = os.path.abspath(os.path.join(concore_path, graphml_file)) #path for ./build
if not os.path.exists(dir_path):
proc = call(["./makestudy", makestudy_dir], cwd=concore_path)
proc = call(["makestudy", makestudy_dir],shell=True, cwd=concore_path)

@pradeeban pradeeban Feb 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. So this fix should be repeated for all the methods (clear, run, ...) I believe?

@parteekcoder parteekcoder Feb 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I will update soon

@pradeeban pradeeban Feb 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

if(proc == 0):
resp = jsonify({'message': 'Directory successfully created'})
resp.status_code = 201
else:
resp = jsonify({'message': 'There is an Error'})
resp.status_code = 500
call(["./build"], cwd=dir_path)
else:

@pradeeban pradeeban Feb 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the PRs to be minimal. If you are addressing a bug, the PR should just address that, instead of making the logs more verbose, like here.

@parteekcoder parteekcoder Feb 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I put an else block here as if
If block is not executed then resp object will not be defined and will give error , as resp object is only defined inside IF block

@pradeeban pradeeban Feb 18, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha, sorry, my bad. You are right.

resp= jsonify({"message":"Success"})
resp.status_code=200
call(["build"],shell=True, cwd=dir_path)
return resp


Expand Down