Skip to content

added download method #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradeeban merged 3 commits into from
Jul 7, 2022
Merged

added download method #7

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d338de8
added download method
amit-62 Jul 6, 2022
27804bb
updated download test
amit-62 Jul 7, 2022
598b23b
updated download test
amit-62 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fri/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import requests
import os
import webbrowser

# function to test upload() method.
def upload():
Expand Down Expand Up @@ -36,9 +37,12 @@ def execute():

return response.text

# ********
# To Download call the url .../download/test?fetch=<filename>&apikey=xyz
# or
def download():
url = "http://127.0.0.1:5000/download/test?fetch=f1.txt&apikey=xyz"
webbrowser.open(url)

@pradeeban pradeeban Jul 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are opening a web browser in the call to the download() method. I think you should just receive the HTTP Response stream and save it as a file. Check how this is handled in CONTROL-CORE Mediator:

def ctl(dir=None):

This may be more complex than just opening the browser.

Python has the means to save the HTTP response streams to enable the download() options without relying on an external webbrowser.


upload()
execute()
download()