fix: ios crash

Author: viniciusddrft

Camera/CaptureSessionController.swift

@@ -30,6 +30,8 @@ final class CaptureSessionController: NSObject {
 
     private(set) var isHDREnabled: Bool = false
     private var desiredTorchEnabled: Bool = false
+    private var cachedZoomFactor: CGFloat = 1.0
+    private var cachedIsTorchSupported: Bool = false
 
     // Current camera position convenience
     var currentPosition: AVCaptureDevice.Position {
@@ -73,6 +75,7 @@ final class CaptureSessionController: NSObject {
                 // Video device: prefer virtual devices/TrueDepth; default to requested position
                 let device = try self.findBestCamera(for: position)
                 self.videoDevice = device
+                self.cachedIsTorchSupported = device.hasTorch && device.isTorchAvailable
 
                 // Remove existing inputs
                 if let existingVideo = self.videoDeviceInput {
@@ -130,6 +133,7 @@ final class CaptureSessionController: NSObject {
                         let maxZ = dev.maxAvailableVideoZoomFactor
                         let target: CGFloat = max(minZ, min(1.0, maxZ))
                         dev.videoZoomFactor = target
+                        self.cachedZoomFactor = target
                         dev.unlockForConfiguration()
                     } catch {
                         // Fallback to async setter if locking fails
@@ -199,6 +203,7 @@ final class CaptureSessionController: NSObject {
             let minZ = device.minAvailableVideoZoomFactor
             let maxZ = device.maxAvailableVideoZoomFactor
             let target = max(minZ, min(maxZ, factor))
+            self.cachedZoomFactor = target
             do {
                 try device.lockForConfiguration()
                 if animated {
@@ -219,6 +224,7 @@ final class CaptureSessionController: NSObject {
             let minZoom = device.minAvailableVideoZoomFactor
             let maxZoom = min(device.maxAvailableVideoZoomFactor, 6.0) // Limit for quality
             let clamped = max(minZoom, min(factor, maxZoom))
+            self.cachedZoomFactor = clamped
             do {
                 try device.lockForConfiguration()
                 if animated {
@@ -237,13 +243,7 @@ final class CaptureSessionController: NSObject {
     }
 
     func currentZoomFactor() -> CGFloat {
-        var value: CGFloat = 1.0
-        sessionQueue.sync {
-            if let device = self.videoDevice {
-                value = device.videoZoomFactor
-            }
-        }
-        return value
+        return cachedZoomFactor
     }
 
 
@@ -437,14 +437,17 @@ final class CaptureSessionController: NSObject {
     func setPreferredCodecHEVC(_ enabled: Bool) {
         sessionQueue.async {
             guard let output = self.movieFileOutput,
+                  !output.isRecording,
                   let connection = output.connection(with: .video) else { return }
+            
             let available = output.availableVideoCodecTypes
+            
+            // It's safer to only set this if we're not recording and the codec is available.
+            // On some devices, setting this can cause a crash if the format doesn't support it.
             if enabled, available.contains(.hevc) {
                 output.setOutputSettings([AVVideoCodecKey: AVVideoCodecType.hevc], for: connection)
             } else if available.contains(.h264) {
                 output.setOutputSettings([AVVideoCodecKey: AVVideoCodecType.h264], for: connection)
-            } else {
-                output.setOutputSettings(nil, for: connection)
             }
         }
     }
@@ -490,6 +493,7 @@ final class CaptureSessionController: NSObject {
         session.addInput(newInput)
         self.videoDeviceInput = newInput
         self.videoDevice = device
+        self.cachedIsTorchSupported = device.hasTorch && device.isTorchAvailable
 
         // Ensure movie output exists
         if self.movieFileOutput == nil {
@@ -528,13 +532,7 @@ final class CaptureSessionController: NSObject {
 
     // MARK: - Torch (Flash)
     func isTorchSupported() -> Bool {
-        var supported = false
-        sessionQueue.sync {
-            if let device = self.videoDevice {
-                supported = device.hasTorch && device.isTorchAvailable
-            }
-        }
-        return supported
+        return cachedIsTorchSupported
     }
 
     func setTorchEnabled(_ enabled: Bool) {