Skip to content

Commit 933e89d

Browse files
committed
chore: import Tactic.Attr.Register privately (leanprover-community#32541)
This is mostly to start a discussion: Should basic tactic files like this one be re-exported by all files out of them being basic, or whether they should be explicitly imported by the few files that actually need it. Eg in leanprover-community#32245 Andrew and I are adding a new simp attribute, and it's a bit silly that we have to rebuild all of mathlib because that file is re-exported everywhere.
1 parent 24d904e commit 933e89d

20 files changed

Lines changed: 39 additions & 6 deletions

File tree

Mathlib/Algebra/Free.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ public import Mathlib.Control.Traversable.Basic
1212
public import Mathlib.Logic.Equiv.Defs
1313
public import Mathlib.Tactic.AdaptationNote
1414

15+
import Mathlib.Tactic.Attr.Register
16+
1517
/-!
1618
# Free constructions
1719

Mathlib/Algebra/Group/Units/Basic.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ public import Mathlib.Tactic.Lift
1313
public import Mathlib.Tactic.Subsingleton
1414
public import Mathlib.Tactic.Attr.Core
1515

16+
import Mathlib.Tactic.Attr.Register
17+
1618
/-!
1719
# Units (i.e., invertible elements) of a monoid
1820

Mathlib/CategoryTheory/Monoidal/Mon_.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ public import Mathlib.CategoryTheory.Monoidal.CoherenceLemmas
1111
public import Mathlib.CategoryTheory.Monoidal.Discrete
1212
public import Mathlib.CategoryTheory.Limits.Shapes.Terminal
1313

14+
import Mathlib.Tactic.Attr.Register
15+
1416
/-!
1517
# The category of monoids in a monoidal category.
1618

Mathlib/Control/Applicative.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ public import Mathlib.Algebra.Group.Defs
99
public import Mathlib.Control.Functor
1010
public import Mathlib.Control.Basic
1111

12+
import Mathlib.Tactic.Attr.Register
13+
1214
/-!
1315
# `applicative` instances
1416

Mathlib/Control/Basic.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ public import Mathlib.Control.Combinators
99
public import Mathlib.Tactic.CasesM
1010
public import Mathlib.Tactic.Attr.Core
1111

12+
import Mathlib.Tactic.Attr.Register
13+
1214
/-!
1315
Extends the theory on functors, applicatives and monads.
1416
-/

Mathlib/Control/Functor.lean

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ Authors: Simon Hudon
55
-/
66
module
77

8-
public import Mathlib.Tactic.Attr.Register
98
public import Mathlib.Data.Set.Defs
109
public import Mathlib.Tactic.TypeStar
1110

11+
import Mathlib.Tactic.Attr.Register
12+
1213
/-!
1314
# Functors
1415

Mathlib/Control/Monad/Basic.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ module
88
public import Mathlib.Logic.Equiv.Defs
99
public import Batteries.Lean.Except
1010

11+
import Mathlib.Tactic.Attr.Register
12+
1113
/-!
1214
# Monad
1315

Mathlib/Control/Traversable/Basic.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ public import Mathlib.Control.Functor
1010
public import Batteries.Data.List.Basic
1111
public import Mathlib.Control.Basic
1212

13+
import Mathlib.Tactic.Attr.Register
14+
1315
/-!
1416
# Traversable type class
1517

Mathlib/Control/Traversable/Equiv.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ public import Mathlib.Control.Traversable.Lemmas
99
public import Mathlib.Logic.Equiv.Defs
1010
public import Batteries.Tactic.SeqFocus
1111

12+
import Mathlib.Tactic.Attr.Register
13+
1214
/-!
1315
# Transferring `Traversable` instances along isomorphisms
1416

Mathlib/Control/Traversable/Lemmas.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ module
88
public import Mathlib.Control.Applicative
99
public import Mathlib.Control.Traversable.Basic
1010

11+
import Mathlib.Tactic.Attr.Register
12+
1113
/-!
1214
# Traversing collections
1315

0 commit comments

Comments
 (0)