fix: update player intro facing logic to use spawn room center instead of world center

Author: CoolSpring8

src/GameScene.ts

@@ -648,18 +648,25 @@ export class GameScene extends Phaser.Scene {
     this.accumulator = 0;
     this.freezeTimer = 0;
     this.syncCurrentRoomToPoint(this.spawnX, this.spawnY);
+    const spawnRoom = findRoomAtPoint(this.rooms, this.spawnX, this.spawnY) ?? this.currentRoom;
+    const facingCenterX = spawnRoom.bounds.x + spawnRoom.bounds.w * 0.5;
     if (introType === "respawn") {
-      const respawnRoom = findRoomAtPoint(this.rooms, this.spawnX, this.spawnY) ?? this.currentRoom;
       const clampedSource = clampRespawnSource(sourceX, sourceY, {
-        left: respawnRoom.bounds.x,
-        right: respawnRoom.bounds.x + respawnRoom.bounds.w,
-        top: respawnRoom.bounds.y,
-        bottom: respawnRoom.bounds.y + respawnRoom.bounds.h,
+        left: spawnRoom.bounds.x,
+        right: spawnRoom.bounds.x + spawnRoom.bounds.w,
+        top: spawnRoom.bounds.y,
+        bottom: spawnRoom.bounds.y + spawnRoom.bounds.h,
       });
       this.player.reviveAt(this.spawnX, this.spawnY, {
         type: "respawn",
         sourceX: clampedSource.x,
         sourceY: clampedSource.y,
+        facingCenterX,
+      });
+    } else if (introType === "start") {
+      this.player.reviveAt(this.spawnX, this.spawnY, {
+        type: "start",
+        facingCenterX,
       });
     } else {
       this.player.reviveAt(this.spawnX, this.spawnY, introType);

src/player/Player.ts

@@ -524,7 +524,7 @@ export class Player extends Actor {
     const introSpec: PlayerIntroSpec = typeof intro === "string" ? { type: intro } : intro;
     this.resetStateAt(x, y);
     this.syncStateAfterExternalMove();
-    this.alignFacingForIntro(x, introSpec.type);
+    this.alignFacingForIntro(x, introSpec);
 
     if (!isActivePlayerIntroSpec(introSpec)) {
       return;
@@ -655,13 +655,14 @@ export class Player extends Actor {
     this.introSourceY = null;
   }
 
-  private alignFacingForIntro(x: number, introType: PlayerIntroType): void {
-    if (introType === "none") {
+  private alignFacingForIntro(x: number, introSpec: PlayerIntroSpec): void {
+    if (introSpec.type === "none") {
       return;
     }
 
-    const worldCenterX = (this.world.cols * WORLD.tile) * 0.5;
-    this.facing = x > worldCenterX ? -1 : 1;
+    const defaultCenterX = (this.world.cols * WORLD.tile) * 0.5;
+    const compareCenterX = introSpec.facingCenterX ?? defaultCenterX;
+    this.facing = x > compareCenterX ? -1 : 1;
     this.lastAim = { x: this.facing, y: 0 };
   }
 

src/player/intro.ts

@@ -12,6 +12,7 @@ export interface PlayerIntroSpec {
   type: PlayerIntroType;
   sourceX?: number;
   sourceY?: number;
+  facingCenterX?: number;
   duration?: number;
 }
 

tests/model/player-intro.test.ts

@@ -58,6 +58,24 @@ describe("Player intro lifecycle", () => {
     expect(snapshot.facing).toBe(1);
   });
 
+  test("intro facing uses the spawn room center instead of the global world center", () => {
+    const specs: Parameters<typeof buildWorld>[0] = [];
+    withFloor(specs);
+    const world = buildWorld(specs);
+    const player = createPlayer(world, 300, 20 * WORLD.tile);
+
+    player.reviveAt(300, 20 * WORLD.tile, {
+      type: "respawn",
+      sourceX: 260,
+      sourceY: 120,
+      facingCenterX: 340,
+    });
+
+    const snapshot = player.getSnapshot();
+    expect(snapshot.state).toBe("intro_respawn");
+    expect(snapshot.facing).toBe(1);
+  });
+
   test("intro type none revives directly into normal control without intro state", () => {
     const specs: Parameters<typeof buildWorld>[0] = [];
     withFloor(specs);