Skip to content

Refactor: Replace LibBoostAsioHandler deadline_timer with steady_timer (pt 2) #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerodefect wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: Replace LibBoostAsioHandler deadline_timer with steady_timer (pt 2) #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions include/amqpcpp/libboostasio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@
/**
* Dependencies
*/
#include <chrono>
#include <memory>

#include <boost/asio/io_context.hpp>
#include <boost/asio/strand.hpp>
#include <boost/asio/deadline_timer.hpp>
#include <boost/asio/steady_timer.hpp>
#include <boost/asio/posix/stream_descriptor.hpp>
#include <boost/asio/dispatch.hpp>
#include <boost/bind/bind.hpp>
Expand Down Expand Up @@ -84,10 +85,10 @@ class LibBoostAsioHandler : public virtual TcpHandler
boost::asio::posix::stream_descriptor _socket;

/**
* The boost asynchronous deadline timer.
* @var class boost::asio::deadline_timer
* The boost asynchronous steady timer.
* @var class boost::asio::steady_timer
*/
boost::asio::deadline_timer _timer;
boost::asio::steady_timer _timer;

/**
* A boolean that indicates if the watcher is monitoring for read events.
Expand Down Expand Up @@ -297,7 +298,7 @@ class LibBoostAsioHandler : public virtual TcpHandler
}

// Reschedule the timer for the future:
_timer.expires_at(_timer.expires_at() + boost::posix_time::seconds(timeout));
_timer.expires_at(_timer.expiry() + std::chrono::seconds(timeout));

// Posts the timer event
_timer.async_wait(get_timer_handler(connection, timeout));
Expand Down Expand Up @@ -388,7 +389,7 @@ class LibBoostAsioHandler : public virtual TcpHandler
stop_timer();

// Reschedule the timer for the future:
_timer.expires_from_now(boost::posix_time::seconds(timeout));
_timer.expires_after(std::chrono::seconds(timeout));

// Posts the timer event
_timer.async_wait(get_timer_handler(connection, timeout));
Expand Down