refactor(core): add tool_use instructions only when needed#1405
Closed
deathbeam wants to merge 1 commit into
Closed
refactor(core): add tool_use instructions only when needed#1405deathbeam wants to merge 1 commit into
deathbeam wants to merge 1 commit into
Conversation
Previously, tool_use instructions were always appended to the system prompt, even when no tools were selected. This change moves the logic to add tool_use instructions to the ask function, ensuring they are included only when selected_tools is not empty. This optimizes prompt construction and prevents unnecessary instructions from being sent to the model. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
force-pushed
the
optimize-tool-use
branch
from
2efc7e7 to
67eb838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tool_use instructions were always appended to the system prompt, even when no tools were selected. This change moves the logic to add tool_use instructions to the ask function, ensuring they are included only when selected_tools is not empty. This optimizes prompt construction and prevents unnecessary instructions from being sent to the model.