Skip to content

Commit 011028b

Browse files
committed
test: bedrock test mock consistency and deprecated event listener
1 parent 33d8a36 commit 011028b

2 files changed

Lines changed: 7 additions & 33 deletions

File tree

src/__tests__/bedrock-stream.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,6 @@ function postPartialBinary(
187187
res.on("error", () => {
188188
aborted = true;
189189
});
190-
res.on("aborted", () => {
191-
aborted = true;
192-
});
193190
res.on("close", () => {
194191
safeResolve({ body: Buffer.concat(chunks), aborted });
195192
});
@@ -1747,7 +1744,7 @@ describe("converseToCompletionRequest (edge cases)", () => {
17471744
},
17481745
"model",
17491746
);
1750-
expect(result.messages[0]).toEqual({ role: "assistant", content: "" });
1747+
expect(result.messages[0]).toEqual({ role: "assistant", content: null });
17511748
});
17521749

17531750
it("handles user tool result with missing text in content items (text ?? '' fallback)", () => {
@@ -1859,8 +1856,8 @@ describe("converseToCompletionRequest (edge cases)", () => {
18591856
"model",
18601857
);
18611858
expect(result.messages[0].tool_calls).toHaveLength(1);
1862-
// Empty text → content is "" (nullish coalescing preserves empty string)
1863-
expect(result.messages[0].content).toBe("");
1859+
// Empty text → content is null (|| coerces empty string to null)
1860+
expect(result.messages[0].content).toBe(null);
18641861
});
18651862
});
18661863

src/__tests__/bedrock.test.ts

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -751,8 +751,8 @@ describe("bedrockToCompletionRequest (edge cases)", () => {
751751
},
752752
"model",
753753
);
754-
// Empty array → no tool_use blocks, textContent is "" → preserved as "" (not coerced to null via ??)
755-
expect(result.messages[0]).toEqual({ role: "assistant", content: "" });
754+
// Empty array → no tool_use blocks, textContent is "" → coerced to null via ||
755+
expect(result.messages[0]).toEqual({ role: "assistant", content: null });
756756
});
757757

758758
it("handles user message with content blocks but no tool_results (text extraction)", () => {
@@ -1650,31 +1650,8 @@ describe("Bedrock webSearches warning", () => {
16501650
response: { content: "Result.", webSearches: ["test"] },
16511651
};
16521652
const journal = new Journal();
1653-
const req = {
1654-
method: undefined,
1655-
url: undefined,
1656-
headers: {},
1657-
} as unknown as http.IncomingMessage;
1658-
const res = {
1659-
_written: "",
1660-
writableEnded: false,
1661-
statusCode: 0,
1662-
writeHead(s: number) {
1663-
this.statusCode = s;
1664-
},
1665-
setHeader() {},
1666-
write(d: string) {
1667-
this._written += d;
1668-
return true;
1669-
},
1670-
end(d?: string) {
1671-
if (d) this._written += d;
1672-
this.writableEnded = true;
1673-
},
1674-
destroy() {
1675-
this.writableEnded = true;
1676-
},
1677-
} as unknown as http.ServerResponse;
1653+
const req = createMockReq();
1654+
const res = createMockRes();
16781655

16791656
await handleBedrock(
16801657
req,

0 commit comments

Comments
 (0)