Skip to content

Commit 495b2df

Browse files
committed
fix: stop creating GitHub issues on drift failure, harden collector
Remove issue creation step from fix-drift workflow — Slack notifications to #oss-alerts remain as the sole alerting channel. Add missing infraIndicators patterns (waitUntil timeout, AssertionError) to drift-report-collector so it classifies WebSocket timeouts and non-drift assertion failures as infrastructure issues instead of crashing with "unparseable test failures."
1 parent ebf5e5f commit 495b2df

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

.github/workflows/fix-drift.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
permissions:
2121
contents: write
2222
pull-requests: write
23-
issues: write
23+
# issues: write # removed — no longer creating issues on drift failure
2424
steps:
2525
- uses: actions/checkout@v4
2626
- uses: pnpm/action-setup@v4
@@ -140,13 +140,6 @@ jobs:
140140
env:
141141
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
142142

143-
# Step 6: Open issue on failure
144-
- name: Create issue on failure
145-
if: failure() && steps.check.outputs.skip != 'true'
146-
run: npx tsx scripts/fix-drift.ts --create-issue
147-
env:
148-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
149-
150143
# Step 7: Slack notification on successful fix
151144
- name: Notify Slack on fix success
152145
if: success() && steps.pr.outputs.url != ''
@@ -165,7 +158,7 @@ jobs:
165158
if: failure() && steps.check.outputs.skip != 'true'
166159
run: |
167160
if [ -z "$SLACK_WEBHOOK" ]; then echo "SLACK_WEBHOOK not set, skipping"; exit 0; fi
168-
MSG="❌ *Drift auto-fix failed* — issue created\nRun: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
161+
MSG="❌ *Drift auto-fix failed* — manual intervention needed\nRun: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
169162
PAYLOAD=$(jq -n --arg text "$MSG" '{text: $text}')
170163
curl -sf -X POST "$SLACK_WEBHOOK" \
171164
-H "Content-Type: application/json" \

scripts/drift-report-collector.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,8 @@ function collectDriftEntries(results: VitestJsonResult): DriftEntry[] {
405405
/API unavailable/i,
406406
/returned no SSE events/i,
407407
/returned empty body/i,
408+
/waitUntil timeout/i,
409+
/AssertionError/i,
408410
];
409411
const driftLikeIndicators = [/drift/i, /mismatch/i, /expected.*but/i, /LLMOCK DRIFT/i];
410412

0 commit comments

Comments
 (0)