Add turnIndex and hasToolResult stateless match criteria#142
Merged
Conversation
commit: |
turnIndex counts assistant messages in the request conversation history. hasToolResult checks for the presence of tool-role messages. Both are stateless and safe for shared aimock instances with concurrent clients. Includes onTurn() convenience method and unit tests.
Cross-provider tests (OpenAI, Anthropic, Gemini), concurrency verification, combined AND-logic, JSON fixture loading, and validateFixtures type/shadowing coverage.
jpr5
force-pushed
the
blitz/aimock-turn-index/integration
branch
from
6b46392 to
48456ba
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turnIndexandhasToolResultas new stateless fixture matching criteria that complement the existingsequenceIndexturnIndexcounts assistant messages in the request's conversation history (0 = first turn, 1 = after first assistant reply, etc.)hasToolResultchecks for the presence/absence of tool-role messages, discriminating pre-tool vs post-tool conversation statesonTurn()convenience method on LLMock for the common turnIndex + userMessage patternvalidateFixturesduplicate-shadowing warning to account for discriminated fixtures (turnIndex/hasToolResult/sequenceIndex)Why
sequenceIndexuses mutable server-side counters that drift when multiple test runners share a single aimock instance. The conversation history already encodes the state thatsequenceIndextracks —turnIndexandhasToolResultextract it statelessly from the request, eliminating counter drift without replacingsequenceIndex(which still serves the "same stateless request repeated N times" use case).Test plan