feat: add reasoning_content support for OpenRouter chat completions#88
Merged
Conversation
commit: |
jpr5
previously approved these changes
Apr 7, 2026
jpr5
left a comment
jpr5
left a comment
Contributor
There was a problem hiding this comment.
PR Review Summary
Reviewed by 7 specialized agents (code-reviewer, silent-failure-hunter, test-analyzer, comment-analyzer, type-design-analyzer, test-file-reviewer, CI/packaging) across all 6 changed files.
Zero actionable findings — clean PR.
The implementation is straightforward and well-executed. reasoning_content is correctly threaded through the full pipeline:
- Types (
SSEDelta,ChatCompletionMessage): optional, not nullable — matches OpenRouter's wire format - Helpers (
buildTextChunks,buildTextCompletion): reasoning chunks emitted before content (streaming), conditional spread for non-streaming — both correct - Server (
handleCompletions): passesresponse.reasoningthrough to both builders — clean plumbing - Stream collapse (
collapseOpenAISSE): extractsreasoning_contentfrom deltas using the same defensive pattern as existing content extraction
Tests are solid — 8 new tests covering streaming ordering, content/reasoning reconstruction, absence cases, and stream-collapse extraction. Assertions are specific (exact string equality, index comparison for ordering), not weak.
One note
The branch is ~21 commits behind main (branched before v1.8.0). A rebase before merge would confirm no conflicts with the reasoning work that landed in PR #81.
🤖 Reviewed with Claude Code
OpenRouter returns reasoning via reasoning_content in the chat completions message/delta format. This adds support for emitting and collapsing reasoning_content in both streaming and non-streaming responses.
jpr5
force-pushed
the
feat/openrouter-reasoning-content
branch
from
fc6a74c to
66e61be
Compare
Contributor
|
Thank you! 🙏 |
This was referenced Apr 8, 2026
Merged
jpr5
added a commit
that referenced
this pull request
Apr 8, 2026
## Summary - **Per-test sequence isolation** via `X-Test-Id` header — each test gets its own fixture match counters across all 12 HTTP + 3 WebSocket handlers (#93) - **Combined content + toolCalls** in fixture responses — new `ContentWithToolCallsResponse` type across OpenAI Chat, Responses, Anthropic Messages, and Gemini with stream collapse support (#92) - **OpenRouter reasoning_content** support (#88) - **Clean URLs** for docs site — all pages restructured as directories, .html extensions removed from links - Fix `web_search_call` items to use `action.query` matching real OpenAI API (#89) - Bump aimock-pytest to 0.3.0 ## Version bumps - `package.json`: 1.8.0 → 1.9.0 - `pyproject.toml`: 0.2.0 → 0.3.0 - `Chart.yaml` appVersion: 1.8.0 → 1.9.0 - `plugin.json` / `marketplace.json`: 1.8.0 → 1.9.0 ## Test plan - [x] All 2206 tests pass (including 80 new clean-URL validation tests) - [x] Build passes - [x] Prettier clean - [ ] npm publish triggers automatically on merge via OIDC workflow - [ ] Verify v1.9.0 appears on npm after merge 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_contentfield to chat completions streaming (delta.reasoning_content) and non-streaming (message.reasoning_content) responsescollapseOpenAISSEto extractreasoning_contentfrom chat completions delta chunks for record-and-replayWhat's included
This PR covers the aimock mock server side — emitting
reasoning_contentin/v1/chat/completionsresponses when a fixture hasreasoningset. It does NOT cover any additional OpenRouter-specific behavior (e.g.reasoning_details, model routing, provider preferences). Those may need separate work.Files changed
src/types.ts— addedreasoning_contenttoSSEDeltaandChatCompletionMessagesrc/helpers.ts—buildTextChunksandbuildTextCompletionnow accept and emit reasoningsrc/server.ts— passesresponse.reasoningthrough to chat completions builderssrc/stream-collapse.ts— extractsreasoning_contentfrom chat completions deltasTest plan
🤖 Generated with Claude Code