refactor: simplify wait helpers, remove duplicated early-out checks

First frame check (frameCount 0 % 30 == 0) handles the already-complete
case naturally. Removed try/catch — let exceptions propagate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Sebastian Muehr

MCPForUnity/Editor/Tools/ManageAssetStore.cs

@@ -983,14 +983,13 @@ private static object GetPackageManagerRoot()
 
         private static Task WaitForOperationAsync(object listOp, TimeSpan timeout)
         {
-            // Check immediately — operation may already be done
             if (listOp == null || _listOperationType == null)
                 return Task.CompletedTask;
 
             var prop = _listOperationType.GetProperties(
                     BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance)
                 .FirstOrDefault(p => p.Name == "isInProgress");
-            if (prop == null || !(bool)(prop.GetValue(listOp) ?? false))
+            if (prop == null)
                 return Task.CompletedTask;
 
             var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
@@ -999,33 +998,10 @@ private static Task WaitForOperationAsync(object listOp, TimeSpan timeout)
 
             void Tick()
             {
-                if (tcs.Task.IsCompleted)
-                {
-                    EditorApplication.update -= Tick;
-                    return;
-                }
+                if (tcs.Task.IsCompleted) { EditorApplication.update -= Tick; return; }
+                if (frameCount++ % 30 != 0) return;
 
-                // Check every ~30 frames (~0.5s at 60fps)
-                if (++frameCount % 30 != 0)
-                    return;
-
-                if ((DateTime.UtcNow - start) > timeout)
-                {
-                    EditorApplication.update -= Tick;
-                    tcs.TrySetResult(true);
-                    return;
-                }
-
-                try
-                {
-                    bool isInProgress = (bool)(prop.GetValue(listOp) ?? false);
-                    if (!isInProgress)
-                    {
-                        EditorApplication.update -= Tick;
-                        tcs.TrySetResult(true);
-                    }
-                }
-                catch
+                if ((DateTime.UtcNow - start) > timeout || !(bool)(prop.GetValue(listOp) ?? false))
                 {
                     EditorApplication.update -= Tick;
                     tcs.TrySetResult(true);
@@ -1038,26 +1014,14 @@ void Tick()
 
         private static Task WaitForDownloadAsync(long productId, TimeSpan timeout)
         {
-            // Check once immediately — download may already be complete
-            var (_, _, alreadyDone, earlyError) = GetDownloadState(productId);
-            if (alreadyDone || !string.IsNullOrEmpty(earlyError))
-                return Task.CompletedTask;
-
             var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
             var start = DateTime.UtcNow;
             int frameCount = 0;
 
             void Tick()
             {
-                if (tcs.Task.IsCompleted)
-                {
-                    EditorApplication.update -= Tick;
-                    return;
-                }
-
-                // Check every ~30 frames (~0.5s at 60fps)
-                if (++frameCount % 30 != 0)
-                    return;
+                if (tcs.Task.IsCompleted) { EditorApplication.update -= Tick; return; }
+                if (frameCount++ % 30 != 0) return;
 
                 if ((DateTime.UtcNow - start) > timeout)
                 {
@@ -1066,16 +1030,8 @@ void Tick()
                     return;
                 }
 
-                try
-                {
-                    var (_, _, completed, error) = GetDownloadState(productId);
-                    if (completed || !string.IsNullOrEmpty(error))
-                    {
-                        EditorApplication.update -= Tick;
-                        tcs.TrySetResult(true);
-                    }
-                }
-                catch
+                var (_, _, completed, error) = GetDownloadState(productId);
+                if (completed || !string.IsNullOrEmpty(error))
                 {
                     EditorApplication.update -= Tick;
                     tcs.TrySetResult(true);