Skip to content

Commit de979e9

Browse files
authored
Remove some of the swiftlint generated warnings (#229)
1 parent 5c5b3f2 commit de979e9

6 files changed

Lines changed: 10 additions & 15 deletions

File tree

Sources/XMLCoder/Decoder/DecodingErrorExtension.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88

99
import Foundation
1010

11-
//===----------------------------------------------------------------------===//
12-
// Error Utilities
13-
//===----------------------------------------------------------------------===//
11+
// MARK: - Error Utilities
1412

1513
extension DecodingError {
1614
/// Returns a `.typeMismatch` error describing the expected type.

Sources/XMLCoder/Decoder/XMLDecoder.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88

99
import Foundation
1010

11-
//===----------------------------------------------------------------------===//
12-
// XML Decoder
13-
//===----------------------------------------------------------------------===//
11+
// MARK: - XML Decoder
1412

1513
/// `XMLDecoder` facilitates the decoding of XML into semantic `Decodable` types.
1614
open class XMLDecoder {

Tests/XMLCoderTests/Auxiliary/XMLElementTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class XMLElementTests: XCTestCase {
4949
XCTAssertEqual(keyed.elements, [element])
5050
XCTAssertEqual(keyed.attributes, [])
5151
}
52-
52+
5353
func testWhitespaceWithNoElements_keyed() {
5454
let keyed = XMLCoderElement(key: "foo", isStringBoxCDATA: false, box: StringBox("bar"))
5555
XCTAssertFalse(keyed.isWhitespaceWithNoElements())
@@ -95,7 +95,7 @@ class XMLElementTests: XCTestCase {
9595
<Input xmlns="https://example.com"><Nested xmlns:xsi="https://example.com" xsi:someName="nestedAttrValue"></Nested></Input>
9696
""")
9797
}
98-
98+
9999
func testNestedElementWith_Namespace_Attribute_Element() {
100100
typealias Attribute = XMLCoderElement.Attribute
101101
typealias Element = XMLCoderElement

Tests/XMLCoderTests/Auxiliary/XMLStackParserTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class XMLStackParserTests: XCTestCase {
110110

111111
XCTAssertEqual(root.elements[0].key, "")
112112
XCTAssertEqual(root.elements[0].stringValue, "\n ")
113-
113+
114114
XCTAssertEqual(root.elements[1].key, "nestedStringList")
115115
XCTAssertEqual(root.elements[1].elements[0].key, "")
116116
XCTAssertEqual(root.elements[1].elements[0].stringValue, "\n ")
@@ -127,7 +127,7 @@ class XMLStackParserTests: XCTestCase {
127127
XCTAssertEqual(root.elements[1].elements[3].elements[3].key, "member")
128128
XCTAssertEqual(root.elements[1].elements[3].elements[3].elements[0].stringValue, "qux")
129129
}
130-
130+
131131
func testEscapableCharacters_removeWhitespaceElements() throws {
132132
let parser = XMLStackParser(trimValueWhitespaces: false, removeWhitespaceElements: true)
133133
let xmlData =
@@ -142,7 +142,7 @@ class XMLStackParserTests: XCTestCase {
142142
XCTAssertEqual(root.elements[0].key, "strValue")
143143
XCTAssertEqual(root.elements[0].elements[0].stringValue, "escaped data: &lt;\r\n")
144144
}
145-
145+
146146
func testEscapableCharacters() throws {
147147
let parser = XMLStackParser(trimValueWhitespaces: false, removeWhitespaceElements: false)
148148
let xmlData =

Tests/XMLCoderTests/Minimal/NestedStringList.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ class NestedStringList: XCTestCase {
2828
let containerValues = try decoder.container(keyedBy: CodingKeys.self)
2929
let nestedStringListWrappedContainer = try containerValues.nestedContainer(keyedBy: NestedMemberKeys.self, forKey: .nestedStringList)
3030
let nestedStringListContainer = try nestedStringListWrappedContainer.decodeIfPresent([[String]].self, forKey: .member)
31-
var nestedStringListBuffer:[[String]] = []
31+
var nestedStringListBuffer: [[String]] = []
3232
if let nestedStringListContainer = nestedStringListContainer {
3333
nestedStringListBuffer = [[String]]()
34-
var listBuffer0: [String]? = nil
34+
var listBuffer0: [String]?
3535
for listContainer0 in nestedStringListContainer {
3636
listBuffer0 = [String]()
3737
for stringContainer1 in listContainer0 {

Tests/XMLCoderTests/Minimal/StringTests.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ class StringTests: XCTestCase {
1616
}
1717

1818
let values: [(Value, String)] = [
19-
// FIXME!
20-
// ("", ""),
19+
("", ""),
2120
("false", "false"),
2221
("-42", "-42"),
2322
("42", "42"),

0 commit comments

Comments
 (0)