feat(security): add CSP, Permissions-Policy and a request body limit#477
Open
NickAldewereld wants to merge 1 commit into
Open
feat(security): add CSP, Permissions-Policy and a request body limit#477NickAldewereld wants to merge 1 commit into
NickAldewereld wants to merge 1 commit into
Conversation
…imit secureHeaders() was called with no options, so no Content-Security-Policy or Permissions-Policy was emitted. Add an explicit CSP (default-src 'self', object-src 'none', frame-ancestors 'none', ...) and a minimal Permissions-Policy. Also add hono/body-limit so oversized request bodies are rejected while streaming instead of being fully buffered and parsed into memory before the per-note size check runs (unbounded-body memory-exhaustion DoS).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small HTTP-layer hardening changes in
server.ts:secureHeaders()was called with no options, so noContent-Security-PolicyorPermissions-Policywas emitted (HSTS / nosniff / X-Frame-Options were already on by default). Adds an explicit CSP (default-src 'self',object-src 'none',frame-ancestors 'none', …) and a minimalPermissions-Policy. The CSP allows'unsafe-inline'for styles anddata:images/fonts, which the client currently needs.hono/body-limitsized tomaxEncryptedPayloadLength(+ envelope). Without it, request bodies were fully buffered and JSON-parsed into memory before the per-note size check, so an oversized body was buffered in full before rejection. With the limit, oversized bodies are rejected while streaming.Lint, typecheck, tests and build pass.