presumably showing that SimpleJSON can handle bad responses

Author: bbarker

src/JSON/Util.js

@@ -1,5 +1,9 @@
 "use strict";
 
+let unsafeIsOk = function (val) {
+  return !( typeof val === 'undefined' || val === null );
+}
+
 exports.tryPrettyJson = function (jString) {
   var jsPretty = jString;
   return function() {
@@ -17,11 +21,16 @@ exports.tryPrettyJson = function (jString) {
 
 exports.preParse = function (jString) {
   var jsObj = JSON.parse(jString)
-  jsObj['data']['attributes']['xml'] = undefined;
-  var strOut = JSON.stringify(jsObj);
-  if (strOut === undefined || strOut === null) {
-    return "";
-  } else {
-    return strOut
-  }
+  if (unsafeIsOk(jsObj.data)
+      && unsafeIsOk(jsObj.data.attributes)
+      &&  unsafeIsOk(jsObj.data.attributes.xml)
+      ) {
+        jsObj['data']['attributes']['xml'] = undefined;
+        var strOut = JSON.stringify(jsObj);
+        if (strOut === undefined || strOut === null) {
+          return "";
+        } else {
+          return strOut
+        }
+      };
 };

test/Main.purs

@@ -42,8 +42,17 @@ main = do
   log $ show $ jsonFiles
   runTest do
     suite "JSON functions" do
+      test "Can handle bad affjax response" testBadResponse
       test "Basic JSON success" $ traverse_ testJsonFile jsonFiles
 
+testBadResponse :: Test
+testBadResponse = do
+  let jsonResW = readRecordJSON respBody
+  let (Tuple jsonRes errs) = runWriter $ unwrap jsonResW
+  logNonFatals "NonFatal errors in parsing bad response" errs
+  assert "not isLeft on bad response" $ isLeft jsonRes
+  where
+    respBody = "{\"errors\":[{\"status\":\"404\",\"title\":\"The resource you are looking for doesn't exist.\"}]}"
 
 -- | Basic tests to see if parsing didn't fantastically fail.
 testJsonFile :: FilePath -> Test