Small cleanup

Author: CorruptComputer

ReQuesty.Builder/CodeDOM/CodeProperty.cs

@@ -1,62 +1,65 @@
 namespace ReQuesty.Builder.CodeDOM;
+
 public enum CodePropertyKind
 {
     Custom,
     RequestBuilder,
     AdditionalData,
     BackingStore,
     UrlTemplate,
+
     /// <summary>
-    /// The set of parameters to be carried over to the next request builder.
+    ///   The set of parameters to be carried over to the next request builder.
     /// </summary>
     PathParameters,
+
     RequestAdapter,
+
     /// <summary>
-    /// The request body. Used when request parameters are wrapped in a class.
+    ///   The request body. Used when request parameters are wrapped in a class.
     /// </summary>
     RequestBody,
+
     /// <summary>
-    /// A request query parameter. Property of the query parameters class.
+    ///   A request query parameter. Property of the query parameters class.
     /// </summary>
     QueryParameter,
+
     /// <summary>
-    /// The request query parameters. Used when request parameters are wrapped in a class.
+    ///   The request query parameters. Used when request parameters are wrapped in a class.
     /// </summary>
     QueryParameters,
+
     /// <summary>
-    /// The request headers. Used when request parameters are wrapped in a class.
+    ///   The request headers. Used when request parameters are wrapped in a class.
     /// </summary>
     Headers,
+
     /// <summary>
-    /// The request middleware options. Used when request parameters are wrapped in a class.
+    ///   The request middleware options. Used when request parameters are wrapped in a class.
     /// </summary>
     Options,
+
     /// <summary>
-    /// The override for the error message for the error/exception type.
+    ///   The override for the error message for the error/exception type.
     /// </summary>
     ErrorMessageOverride
 }
 
 public class CodeProperty : CodeTerminalWithKind<CodePropertyKind>, IDocumentedElement, IAlternativeName, ICloneable, IDeprecableElement, IAccessibleElement
 {
-    public bool ReadOnly
-    {
-        get; set;
-    }
+    public bool ReadOnly { get; set; }
+
     public AccessModifier Access { get; set; } = AccessModifier.Public;
+
     public bool ExistsInBaseType => OriginalPropertyFromBaseType != null;
-    public bool ExistsInExternalBaseType
-    {
-        get; set;
-    }
-    public CodeMethod? Getter
-    {
-        get; set;
-    }
-    public CodeMethod? Setter
-    {
-        get; set;
-    }
+
+    public bool ExistsInExternalBaseType { get; set; }
+
+    public CodeMethod? Getter { get; set; }
+
+    public CodeMethod? Setter { get; set; }
+
     public CodeMethod? GetterFromCurrentOrBaseType
     {
         get
@@ -74,6 +77,7 @@ public CodeMethod? GetterFromCurrentOrBaseType
             return default;
         }
     }
+
     public CodeMethod? SetterFromCurrentOrBaseType
     {
         get
@@ -91,7 +95,8 @@ public CodeMethod? SetterFromCurrentOrBaseType
             return default;
         }
     }
-#nullable disable // the backing property is required
+
+#nullable disable // the property is required
     private CodeTypeBase type;
 #nullable enable
     public required CodeTypeBase Type
@@ -103,28 +108,31 @@ public required CodeTypeBase Type
             type = value;
         }
     }
+
     public string DefaultValue { get; set; } = string.Empty;
+
     public CodeDocumentation Documentation { get; set; } = new();
+
     /// <inheritdoc/>
     public string SerializationName { get; set; } = string.Empty;
+
     public string NamePrefix { get; set; } = string.Empty;
+
     /// <inheritdoc/>
     public bool IsNameEscaped
     {
         get => !string.IsNullOrEmpty(SerializationName);
     }
+
     /// <inheritdoc/>
     public string WireName => IsNameEscaped ? SerializationName : Name;
-    public CodeProperty? OriginalPropertyFromBaseType
-    {
-        get; set;
-    }
-    public DeprecationInformation? Deprecation
-    {
-        get; set;
-    }
+
+    public CodeProperty? OriginalPropertyFromBaseType { get; set; }
+
+    public DeprecationInformation? Deprecation { get; set; }
+
     /// <summary>
-    /// Indicates if the property is the primary error message for the error/exception type.
+    ///   Indicates if the property is the primary error message for the error/exception type.
     /// </summary>
     public bool IsPrimaryErrorMessage
     {
@@ -150,8 +158,9 @@ public object Clone()
             NamePrefix = NamePrefix,
             OriginalPropertyFromBaseType = OriginalPropertyFromBaseType?.Clone() as CodeProperty,
             Deprecation = Deprecation,
-            IsPrimaryErrorMessage = IsPrimaryErrorMessage,
+            IsPrimaryErrorMessage = IsPrimaryErrorMessage
         };
+
         return property;
     }
 }

ReQuesty.Builder/CodeDOM/CodeType.cs

@@ -38,6 +38,7 @@ public override object Clone()
             // e.g. var y = x.Clone(); var z = y.Clone(); y.GenericTypeParameterValues.Add(value);
             // shouldn't modify x.GenericTypeParameterValues or z.GenericTypeParameterValues
             genericTypeParameterValues = [.. genericTypeParameterValues],
+            IsNullable = IsNullable
         }.BaseClone<CodeType>(this, TypeDefinition is null || IsExternal);
     }
     public IEnumerable<CodeType> GenericTypeParameterValues

ReQuesty.Builder/CodeDOM/CodeTypeBase.cs

@@ -1,4 +1,5 @@
 namespace ReQuesty.Builder.CodeDOM;
+
 public abstract class CodeTypeBase : CodeTerminal, ICloneable
 {
     public enum CodeTypeCollectionKind
@@ -9,30 +10,32 @@ public enum CodeTypeCollectionKind
     }
 
     /// <summary>
-    /// Indicates that the type is a callback
-    /// Example: ActionOf:true parameterA: (y: typeA) => void
-    /// Example: ActionOf:false parameterA: typeA
+    ///   Indicates that the type is a callback
+    ///   Example: ActionOf:true parameterA: (y: typeA) => void
+    ///   Example: ActionOf:false parameterA: typeA
     /// </summary>
-    public bool ActionOf
-    {
-        get; set;
-    }
+    public bool ActionOf { get; set; }
+
     public bool IsNullable { get; set; }
+
     public CodeTypeCollectionKind CollectionKind { get; set; } = CodeTypeCollectionKind.None;
+
     public bool IsCollection
     {
         get
         {
             return CollectionKind != CodeTypeCollectionKind.None;
         }
     }
+
     public bool IsArray
     {
         get
         {
             return CollectionKind == CodeTypeCollectionKind.Array;
         }
     }
+
     protected virtual TChildType BaseClone<TChildType>(CodeTypeBase source, bool cloneName = true) where TChildType : CodeTypeBase
     {
         ArgumentNullException.ThrowIfNull(source);

ReQuesty.Builder/Writers/CSharp/CodePropertyWriter.cs

@@ -14,8 +14,8 @@ public override void WriteCodeElement(CodeProperty codeElement, LanguageWriter w
         }
 
         string propertyType = conventions.GetTypeString(codeElement.Type, codeElement);
-        bool isNullable = codeElement.Type.IsNullable;
 
+        bool isNullable = codeElement.Type.IsNullable;
         if (isNullable && !propertyType.EndsWith('?'))
         {
             propertyType += "?";