[#175]: added repr(C,packed) for monitoring structures. Fixed imports. Added error handling in event listener

Author: LorenzoTettamanti

core/common/src/buffer_type.rs

@@ -86,7 +86,7 @@ unsafe impl aya::Pod for TcpPacketRegistry {}
 #[cfg(feature = "monitoring-structs")]
 pub const TASK_COMM_LEN: usize = 16; // linux/sched.h
 #[cfg(feature = "monitoring-structs")]
-#[repr(C)]
+#[repr(C, packed)]
 #[derive(Clone, Copy, Zeroable)]
 pub struct NetworkMetrics {
     pub tgid: u32,
@@ -104,7 +104,7 @@ pub struct NetworkMetrics {
 unsafe impl aya::Pod for NetworkMetrics {}
 
 #[cfg(feature = "monitoring-structs")]
-#[repr(C)]
+#[repr(C, packed)]
 #[derive(Clone, Copy, Zeroable)]
 pub struct TimeStampMetrics {
     pub delta_us: u64,

core/src/components/identity/src/main.rs

@@ -21,21 +21,21 @@ use aya::{
 #[cfg(feature = "experimental")]
 use crate::helpers::scan_cgroup_cronjob;
 
-use cortexbrain_common::buffer_type::read_perf_buffer;
-use cortexbrain_common::map_handlers::{
-    init_bpf_maps, map_manager, map_pinner, populate_blocklist,
+use cortexbrain_common::{
+    buffer_type::{BufferSize, BufferType, read_perf_buffer},
+    constants, logger,
+    map_handlers::BpfMapsData,
+    map_handlers::{init_bpf_maps, map_manager, map_pinner, populate_blocklist},
+    program_handlers::load_program,
 };
-use cortexbrain_common::program_handlers::load_program;
-use cortexbrain_common::{buffer_type::BufferType, map_handlers::BpfMapsData};
 use std::{
     convert::TryInto,
     path::Path,
     sync::{Arc, Mutex},
 };
 
-use anyhow::{Context, Ok};
-use cortexbrain_common::buffer_type::BufferSize;
-use cortexbrain_common::{constants, logger};
+use anyhow::{Context, Ok, anyhow};
+
 use std::collections::HashMap;
 use tokio::{fs, signal};
 use tracing::{error, info};
@@ -206,7 +206,12 @@ async fn event_listener(bpf_maps: BpfMapsData) -> Result<(), anyhow::Error> {
     // fill the input buffers with data from the PerfEventArrays
     for cpu_id in online_cpus().map_err(|e| anyhow::anyhow!("Error {:?}", e))? {
         for (name, (perf_evt_array, perf_evt_array_buffer)) in maps.iter_mut() {
-            let buf = perf_evt_array.open(cpu_id, None)?;
+            let buf = perf_evt_array.open(cpu_id, None).map_err(|e| {
+                anyhow!(
+                    "Cannot create perf_event_array buffer from perf_event_array. Reason: {}",
+                    e
+                )
+            })?;
             info!(
                 "Buffer created for map {:?} on cpu_id {:?}. Buffer size: {}",
                 name,

core/src/components/metrics/src/helpers.rs

@@ -1,3 +1,4 @@
+use anyhow::anyhow;
 use aya::util::online_cpus;
 use cortexbrain_common::map_handlers::map_manager;
 use cortexbrain_common::{
@@ -16,7 +17,18 @@ pub async fn event_listener(bpf_maps: BpfMapsData) -> Result<(), anyhow::Error>
 
     for cpu_id in cpu_count {
         for (name, (perf_event_array, perf_event_buffer)) in maps.iter_mut() {
-            let buf = perf_event_array.open(cpu_id, None)?;
+            let buf = perf_event_array.open(cpu_id, None).map_err(|e| {
+                anyhow!(
+                    "Cannot create perf_event_array buffer from perf_event_array. Reason: {}",
+                    e
+                )
+            })?;
+            info!(
+                "Buffer created for map {:?} on cpu_id {:?}. Buffer size: {}",
+                name,
+                cpu_id,
+                std::mem::size_of_val(&buf)
+            );
             perf_event_buffer.push(buf);
         }
     }

core/src/components/metrics/src/main.rs

@@ -1,6 +1,5 @@
 use anyhow::{Context, Ok};
 use aya::Ebpf;
-use cortexbrain_common::constants;
 use std::{
     env, fs,
     path::Path,
@@ -11,9 +10,12 @@ use tracing::{error, info};
 mod helpers;
 use crate::helpers::event_listener;
 
-use cortexbrain_common::logger::otlp_logger_init;
-use cortexbrain_common::map_handlers::{init_bpf_maps, map_pinner};
-use cortexbrain_common::program_handlers::load_program;
+use cortexbrain_common::{
+    constants,
+    logger::otlp_logger_init,
+    map_handlers::{init_bpf_maps, map_pinner},
+    program_handlers::load_program,
+};
 
 #[tokio::main]
 async fn main() -> Result<(), anyhow::Error> {

core/src/components/metrics_tracer/src/data_structures.rs

@@ -2,7 +2,7 @@ use aya_ebpf::{macros::map, maps::{LruPerCpuHashMap, HashMap, PerfEventArray}};
 
 pub const TASK_COMM_LEN: usize = 16;
 
-
+#[repr(C,packed)]
 pub struct NetworkMetrics {
     pub tgid: u32,
     pub comm: [u8; TASK_COMM_LEN],
@@ -16,7 +16,7 @@ pub struct NetworkMetrics {
     pub sk_drops: i32,              // Offset 136
 }
 
-#[repr(C)]
+#[repr(C,packed)]
 #[derive(Copy, Clone)]
 pub struct TimeStampStartInfo {
     pub comm: [u8; TASK_COMM_LEN],
@@ -25,7 +25,7 @@ pub struct TimeStampStartInfo {
 }
 
 // Event we send to userspace when latency is computed
-#[repr(C)]
+#[repr(C,packed)]
 #[derive(Copy, Clone)]
 pub struct TimeStampEvent {
     pub delta_us: u64,