[#123]: fixed logging and typos in agent-api- Updated the service type to a NodePort.Fixed typos in Dockerfile

Author: LorenzoTettamanti

core/api/Cargo.toml

@@ -15,6 +15,7 @@ identity = { path = "../src/components/identity" }
 tonic-reflection = "0.14.0"
 tonic-build = "0.14.0"
 dotenv = "0.15.0"
+tracing-subscriber = "0.3.19"
 
 [build-dependencies]
 tonic-build = "0.14.0"

core/api/Dockerfile

@@ -50,7 +50,7 @@ COPY --from=builder /usr/src/app/agent/target/release/identity /usr/local/bin/id
 COPY conntracker /usr/src/cortexbrain-agent/conntracker
 
 # Set env vars for your app
-ENV BPF_PATH="/usr/src/cortexbrain-identity-service/conntracker"
+ENV BPF_PATH="/usr/src/cortexbrain-agent/conntracker"
 ENV PIN_MAP_PATH="/sys/fs/bpf/cortexbrain-identity-service/"
 
 # Default command

core/api/src/api.rs

@@ -35,7 +35,7 @@ const BPF_PATH: &str = "BPF_PATH";
 impl Default for AgentApi {
     fn default() -> Self {
         let bpf_path = std::env::var(BPF_PATH).context("BPF_PATH variable not found").unwrap();
-        let data = fs::read(Path::new(&bpf_path)).context("Cannot load load from path").unwrap();
+        let data = fs::read(Path::new(&bpf_path)).context("Cannot load data from path").unwrap();
 
         AgentApi {
             name: "CortexFlow-Agent".to_string(),

core/api/src/main.rs

@@ -1,5 +1,6 @@
 // module imports
 use tonic::transport::{Error, Server};
+use tracing_subscriber::{fmt::format::FmtSpan, EnvFilter};
 
 mod agent;
 mod api;
@@ -14,32 +15,49 @@ use crate::agent::agent_server::AgentServer;
 use crate::api::AgentApi; //api implementations //from tonic. generated from agent.proto
 
 use tokio::main;
+use tracing::{error, info};
 
 #[main]
 async fn main() -> Result<(), Error> {
-    let address = "127.0.0.1:9090".parse().unwrap();
+    //init tracing subscriber
+    tracing_subscriber::fmt()
+        .with_max_level(tracing::Level::INFO)
+        .with_target(false)
+        .with_level(true)
+        .with_span_events(FmtSpan::NONE)
+        .with_file(false)
+        .pretty()
+        .with_env_filter(EnvFilter::new("info"))
+        .with_line_number(false)
+        .init();
+
+    info!("Starting agent server...");
+    info!("fetching data");
+
+    //FIXME: binding on 0.0.0.0 address is not ideal for a production environment. This will need future fixes
+    let address = "0.0.0.0:9090".parse().unwrap();
     let api = AgentApi::default();
 
     match tonic_reflection::server::Builder::configure()
         .register_encoded_file_descriptor_set(agent_proto::AGENT_DESCRIPTOR)
         .build_v1()
     {
         Ok(reflection_server) => {
-            print!("reflection server started correctly");
+            info!("reflection server started correctly");
             match Server::builder()
                 .add_service(AgentServer::new(api))
                 .add_service(reflection_server)
                 .serve(address)
                 .await
             {
-                Ok(_) => println!("Server started with no errors"),
-                Err(e) => eprintln!(
+                Ok(_) => info!("Server started with no errors"),
+                Err(e) => error!(
                     "An error occured during the Server::builder processe. Error {}",
                     e
                 ),
             }
         }
-        Err(e) => eprintln!(
+        Err(e) => error!(
             "An error occured during the starting of the reflection server. Error {}",
             e
         ),

core/src/testing/agent.yaml

@@ -34,8 +34,11 @@ spec:
               echo "checking privileges"
               ls -ld /sys/fs/bpf
 
+              echo "checking if conntracker path"
+              ls -l /usr/src/cortexbrain-agent/conntracker
+
               echo "Running application..."
-              exec /usr/local/bin/cortexflow-agent || echo "Application exited with code $?"
+              exec /usr/local/bin/agent-api || echo "Application exited with code $?"
           volumeMounts:
             - name: bpf
               mountPath: /sys/fs/bpf
@@ -84,5 +87,5 @@ spec:
     name: agent-server-port
     port: 9090
     targetPort: 9090
-  type: ClusterIP
+  type: NodePort
 ---