Skip to content

Commit 2af0faf

Browse files
authored
Merge pull request #2646 from CortexFoundation/dev
core/rawdb: close directory fd on Readdirnames error in cleanup
2 parents 498ec28 + 64aa49e commit 2af0faf

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

core/rawdb/freezer_resettable.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,13 +221,12 @@ func cleanup(path string) error {
221221
if err != nil {
222222
return err
223223
}
224+
defer dir.Close()
225+
224226
names, err := dir.Readdirnames(0)
225227
if err != nil {
226228
return err
227229
}
228-
if cerr := dir.Close(); cerr != nil {
229-
return cerr
230-
}
231230
for _, name := range names {
232231
if name == filepath.Base(path)+tmpSuffix {
233232
log.Info("Removed leftover freezer directory", "name", name)

0 commit comments

Comments
 (0)