Merge pull request #2376 from CortexFoundation/dev

ucwong · web-flow · commit 8f0fbd005d41 · 2025-06-05T08:59:43.000+01:00
return null for not-found
diff --git a/ctxc/api_backend.go b/ctxc/api_backend.go
@@ -142,7 +142,7 @@ func (b *CortexAPIBackend) BlockByNumberOrHash(ctx context.Context, blockNrOrHas
 	if hash, ok := blockNrOrHash.Hash(); ok {
 		header := b.ctxc.blockchain.GetHeaderByHash(hash)
 		if header == nil {
-			return nil, errors.New("header for hash not found")
+			return nil, nil
 		}
 		if blockNrOrHash.RequireCanonical && b.ctxc.blockchain.GetCanonicalHash(header.Number.Uint64()) != hash {
 			return nil, errors.New("hash is not currently canonical")

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ func (b *CortexAPIBackend) BlockByNumberOrHash(ctx context.Context, blockNrOrHas`
`142`	`142`	`if hash, ok := blockNrOrHash.Hash(); ok {`
`143`	`143`	`header := b.ctxc.blockchain.GetHeaderByHash(hash)`
`144`	`144`	`if header == nil {`
`145`		`- return nil, errors.New("header for hash not found")`
	`145`	`+ return nil, nil`
`146`	`146`	`}`
`147`	`147`	`if blockNrOrHash.RequireCanonical && b.ctxc.blockchain.GetCanonicalHash(header.Number.Uint64()) != hash {`
`148`	`148`	`return nil, errors.New("hash is not currently canonical")`