Skip to content

p2p: better dial/serve success metrics #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucwong merged 1 commit into from
Apr 25, 2025
Merged

p2p: better dial/serve success metrics #2325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions p2p/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ var (
dialSuccessMeter metrics.Meter = metrics.NilMeter{}
dialConnectionError metrics.Meter = metrics.NilMeter{}

// count peers that stayed connected for at least 1 min
serve1MinSuccessMeter = metrics.NewRegisteredMeter("p2p/serves/success/1min", nil)
dial1MinSuccessMeter = metrics.NewRegisteredMeter("p2p/dials/success/1min", nil)

// handshake error meters
dialTooManyPeers = metrics.NewRegisteredMeter("p2p/dials/error/saturated", nil)
dialAlreadyConnected = metrics.NewRegisteredMeter("p2p/dials/error/known", nil)
Expand Down
8 changes: 8 additions & 0 deletions p2p/peer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ func (p *Peer) run() (remoteRequested bool, err error) {
p.wg.Add(2)
go p.readLoop(readErr)
go p.pingLoop()
live1min := time.NewTimer(1 * time.Minute)
defer live1min.Stop()

// Start all protocol handlers.
writeStart <- struct{}{}
Expand Down Expand Up @@ -285,6 +287,12 @@ loop:
case err = <-p.disc:
reason = discReasonForError(err)
break loop
case <-live1min.C:
if p.Inbound() {
serve1MinSuccessMeter.Mark(1)
} else {
dial1MinSuccessMeter.Mark(1)
}
}
}

Expand Down