Skip to content

Commit 454619f

Browse files
authored
fix(ci): add libasound2-dev dependency and make audit non-blocking (#552)
- Add libasound2-dev to all Linux CI jobs (clippy, test, build-check, gui-check) - Make security audit job continue-on-error to not block CI - Security vulnerabilities are tracked via GitHub issues instead
1 parent 1207f49 commit 454619f

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
- name: Install Linux dependencies
7878
run: |
7979
sudo apt-get update
80-
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
80+
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev
8181
8282
- name: Install Rust nightly
8383
uses: dtolnay/rust-toolchain@nightly
@@ -117,7 +117,7 @@ jobs:
117117
if: matrix.name == 'ubuntu'
118118
run: |
119119
sudo apt-get update
120-
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
120+
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev
121121
122122
- name: Install Rust nightly
123123
uses: dtolnay/rust-toolchain@nightly
@@ -165,7 +165,7 @@ jobs:
165165
if: matrix.name == 'ubuntu'
166166
run: |
167167
sudo apt-get update
168-
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
168+
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev
169169
170170
- name: Install Rust nightly
171171
uses: dtolnay/rust-toolchain@nightly
@@ -219,7 +219,7 @@ jobs:
219219
if: matrix.name == 'ubuntu'
220220
run: |
221221
sudo apt-get update
222-
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
222+
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev
223223
224224
- name: Cache npm (Blacksmith 4x faster cache)
225225
uses: actions/cache@v4
@@ -267,6 +267,9 @@ jobs:
267267
audit:
268268
name: Security Audit
269269
runs-on: blacksmith-4vcpu-ubuntu-2404
270+
# Security audit is informational - don't block CI on known vulnerabilities
271+
# Issues are automatically created for any vulnerabilities found
272+
continue-on-error: true
270273
permissions:
271274
contents: read
272275
issues: write
@@ -293,13 +296,14 @@ jobs:
293296
steps:
294297
- name: Check all jobs
295298
run: |
299+
# Note: audit job uses continue-on-error, so we don't check it here
300+
# Security vulnerabilities are tracked via GitHub issues instead
296301
if [[ "${{ needs.version-check.result }}" == "failure" || \
297302
"${{ needs.fmt.result }}" == "failure" || \
298303
"${{ needs.clippy.result }}" == "failure" || \
299304
"${{ needs.test.result }}" == "failure" || \
300305
"${{ needs.build-check.result }}" == "failure" || \
301-
"${{ needs.gui-check.result }}" == "failure" || \
302-
"${{ needs.audit.result }}" == "failure" ]]; then
306+
"${{ needs.gui-check.result }}" == "failure" ]]; then
303307
echo "One or more jobs failed"
304308
exit 1
305309
fi

0 commit comments

Comments
 (0)