fix(tui): improve subagent display format with Factory-style todos (#274)

- Change subagent display from spinner with status to cleaner Factory-style format:
  ● Task {agent_type}
    ⎿ [pending] task1
      [in_progress] task2
      [completed] task3

- Fix duplicate display bug: Task tools are no longer added to both
  tool_calls and active_subagents. They now only appear as subagent tasks
  with proper todo tracking.

- Remove animated spinner for subagents, use solid dot indicator instead
- Show current activity with ⎿ prefix when no todos are available yet

Co-authored-by: Droid Agent <droid@factory.ai>

Author: echobt

cortex-tui/src/runner/event_loop.rs

@@ -2928,9 +2928,12 @@ impl EventLoop {
                     arguments: arguments.clone(),
                 });
 
-                // Add tool call to display
-                self.app_state
-                    .add_tool_call(id.clone(), name.clone(), arguments.clone());
+                // Add tool call to display - but NOT for Task tools
+                // Task tools use SubagentTaskDisplay for better visualization
+                if name != "Task" && name != "task" {
+                    self.app_state
+                        .add_tool_call(id.clone(), name.clone(), arguments.clone());
+                }
 
                 // Special handling for Questions tool - show interactive TUI
                 if name == "Questions" || name == "question" {
@@ -2945,7 +2948,11 @@ impl EventLoop {
 
                 // Special handling for Task and Batch tools - use UnifiedToolExecutor
                 if name == "Task" || name == "task" || name == "Batch" || name == "batch" {
-                    self.app_state.update_tool_status(&id, ToolStatus::Running);
+                    // Note: Task tools don't need update_tool_status here because
+                    // they use SubagentTaskDisplay which has its own status tracking
+                    if name == "Batch" || name == "batch" {
+                        self.app_state.update_tool_status(&id, ToolStatus::Running);
+                    }
 
                     // Use UnifiedToolExecutor if available, otherwise fall back to old behavior
                     if self.unified_executor.is_some() {

cortex-tui/src/views/minimal_session.rs

@@ -379,112 +379,73 @@ impl<'a> MinimalSessionView<'a> {
         lines
     }
 
-    /// Renders a subagent task with animated spinner and progress
+    /// Renders a subagent task with todos in Factory-style format
+    ///
+    /// Format:
+    /// ```
+    /// ● Task {agent_type}
+    ///   ⎿ [pending] task1
+    ///     [in_progress] task2
+    ///     [completed] task3
+    /// ```
     fn render_subagent(&self, task: &SubagentTaskDisplay) -> Vec<Line<'static>> {
-        use crate::ui::consts::TOOL_SPINNER_FRAMES;
+        use crate::app::SubagentTodoStatus;
         let mut lines = Vec::new();
 
-        // Status indicator with color - animated spinner for active status
+        // Status indicator with color
         let (indicator, indicator_color) = match &task.status {
-            SubagentDisplayStatus::Starting => {
-                let frame = TOOL_SPINNER_FRAMES[task.spinner_frame % TOOL_SPINNER_FRAMES.len()];
-                (frame.to_string(), self.colors.warning)
-            }
-            SubagentDisplayStatus::Thinking => {
-                let frame = TOOL_SPINNER_FRAMES[task.spinner_frame % TOOL_SPINNER_FRAMES.len()];
-                (frame.to_string(), self.colors.accent)
-            }
-            SubagentDisplayStatus::ExecutingTool(_) => {
-                let frame = TOOL_SPINNER_FRAMES[task.spinner_frame % TOOL_SPINNER_FRAMES.len()];
-                (frame.to_string(), Color::Blue)
-            }
-            SubagentDisplayStatus::Completed => ("✓".to_string(), self.colors.success),
-            SubagentDisplayStatus::Failed => ("✗".to_string(), self.colors.error),
+            SubagentDisplayStatus::Starting
+            | SubagentDisplayStatus::Thinking
+            | SubagentDisplayStatus::ExecutingTool(_) => ("●", self.colors.accent),
+            SubagentDisplayStatus::Completed => ("●", self.colors.success),
+            SubagentDisplayStatus::Failed => ("●", self.colors.error),
         };
 
-        // Line 1: ◐ [agent_type] description - current_activity (Xs)
-        let elapsed_secs = task.elapsed().as_secs();
+        // Line 1: ● Task {agent_type}
         lines.push(Line::from(vec![
             Span::styled(indicator, Style::default().fg(indicator_color)),
             Span::raw(" "),
             Span::styled(
-                format!("[{}]", task.agent_type),
-                Style::default().fg(self.colors.text_muted),
-            ),
-            Span::raw(" "),
-            Span::styled(
-                task.description.clone(),
+                format!("Task {}", task.agent_type),
                 Style::default()
                     .fg(self.colors.accent)
                     .add_modifier(Modifier::BOLD),
             ),
-            Span::styled(
-                format!(" - {}", task.current_activity),
-                Style::default().fg(self.colors.text_dim),
-            ),
-            Span::styled(
-                format!(" ({}s)", elapsed_secs),
-                Style::default().fg(self.colors.text_muted),
-            ),
         ]));
 
-        // Display todos if any (real-time todo list from subagent)
+        // Display todos if any - use ⎿ prefix for first, space for rest
         if !task.todos.is_empty() {
-            use crate::app::SubagentTodoStatus;
-            for todo in &task.todos {
-                let (status_icon, status_color) = match todo.status {
-                    SubagentTodoStatus::Completed => ("✓", self.colors.success),
-                    SubagentTodoStatus::InProgress => ("●", self.colors.accent),
-                    SubagentTodoStatus::Pending => ("○", self.colors.text_muted),
+            for (i, todo) in task.todos.iter().enumerate() {
+                let (status_text, status_color) = match todo.status {
+                    SubagentTodoStatus::Completed => ("[completed]", self.colors.success),
+                    SubagentTodoStatus::InProgress => ("[in_progress]", self.colors.accent),
+                    SubagentTodoStatus::Pending => ("[pending]", self.colors.text_muted),
                 };
                 // Truncate long todo content
-                let content = if todo.content.len() > 55 {
-                    format!("{}...", &todo.content.chars().take(52).collect::<String>())
+                let content = if todo.content.len() > 50 {
+                    format!("{}...", &todo.content.chars().take(47).collect::<String>())
                 } else {
                     todo.content.clone()
                 };
+                // First line uses ⎿, rest use indentation
+                let prefix = if i == 0 { "  ⎿ " } else { "    " };
                 lines.push(Line::from(vec![
-                    Span::styled("  ", Style::default()),
-                    Span::styled(status_icon, Style::default().fg(status_color)),
+                    Span::styled(prefix, Style::default().fg(self.colors.text_muted)),
+                    Span::styled(status_text, Style::default().fg(status_color)),
                     Span::styled(" ", Style::default()),
                     Span::styled(content, Style::default().fg(self.colors.text_dim)),
                 ]));
             }
-        } else if !task.tool_calls.is_empty() {
-            // Fallback: show tool calls summary if no todos
-            let tool_summary: String = task
-                .tool_calls
-                .iter()
-                .map(|(name, success)| {
-                    if *success {
-                        format!("✓{}", name)
-                    } else {
-                        format!("✗{}", name)
-                    }
-                })
-                .collect::<Vec<_>>()
-                .join(" ");
-
-            lines.push(Line::from(vec![
-                Span::styled("  │ ", Style::default().fg(self.colors.text_muted)),
-                Span::styled(
-                    format!("Tools: {}", tool_summary),
-                    Style::default().fg(self.colors.text_dim),
-                ),
-            ]));
-        } else if !task.output_preview.is_empty() {
-            // Fallback: show output preview if no todos and no tool calls
-            let preview = if task.output_preview.len() > 60 {
-                format!(
-                    "{}...",
-                    &task.output_preview.chars().take(57).collect::<String>()
-                )
+        } else {
+            // No todos yet - show current activity with ⎿
+            let activity = if task.current_activity.is_empty() {
+                "Initializing...".to_string()
             } else {
-                task.output_preview.clone()
+                task.current_activity.clone()
             };
             lines.push(Line::from(vec![
-                Span::styled("  │ ", Style::default().fg(self.colors.text_muted)),
-                Span::styled(preview, Style::default().fg(self.colors.text_dim)),
+                Span::styled("  ⎿ ", Style::default().fg(self.colors.text_muted)),
+                Span::styled(activity, Style::default().fg(self.colors.text_dim)),
             ]));
         }