fix: CI compilation errors across platforms

- Fix set_var unsafe in Rust 2024 edition (cortex-utils-pty)
- Fix ptsname_r not available on macOS (use ptsname instead)
- Fix permissions variable not in scope (cortex-engine/tasks/snapshot.rs)
- Allow expect/unwrap in cortex-protocol tests
- Remove unused import in skills/manager.rs

Author: Factory Bot

ci_logs.txt

@@ -0,0 +1,7 @@
+gh : run 21363633308 is still in progress; logs will be available when it is complete
+Au caractère Ligne:1 : 64
++ ... s\Hi\Documents\cortex-cli; gh run view 21363633308 --log 2>&1 | Out-F ...
++                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    + CategoryInfo          : NotSpecified: (run 21363633308... it is complete:String) [], RemoteException
+    + FullyQualifiedErrorId : NativeCommandError
+ 

clippy_log.txt

@@ -0,0 +1,7 @@
+gh : run 21363633308 is still in progress; logs will be available when it is complete
+Au caractère Ligne:1 : 38
++ ... ocuments\cortex-cli; gh run view --job=61489287108 --log 2>&1 | Out-F ...
++                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    + CategoryInfo          : NotSpecified: (run 21363633308... it is complete:String) [], RemoteException
+    + FullyQualifiedErrorId : NativeCommandError
+ 

cortex-engine/src/skills/manager.rs

@@ -13,7 +13,6 @@ use once_cell::sync::OnceCell;
 use tracing::warn;
 
 use super::{Skill, SkillRegistry, SkillScope};
-use crate::error::Result;
 
 /// Error that occurred while loading a skill.
 #[derive(Debug, Clone)]

cortex-engine/src/tasks/snapshot.rs

@@ -292,7 +292,10 @@ impl SnapshotManager {
             match state {
                 FileState::Exists {
                     content,
-                    permissions: _,
+                    #[cfg(unix)]
+                    permissions,
+                    #[cfg(not(unix))]
+                        permissions: _,
                     ..
                 } => {
                     // Create parent directories

cortex-protocol/src/tests/mod.rs

@@ -1,4 +1,5 @@
 //! Comprehensive tests for Cortex-protocol
+#![allow(clippy::unwrap_used, clippy::expect_used)]
 
 #[cfg(test)]
 pub mod approvals_tests;

cortex-utils/pty/src/pty.rs

@@ -74,6 +74,7 @@ impl UnixPty {
     }
 
     /// Get the name of the slave PTY.
+    #[cfg(target_os = "linux")]
     fn get_slave_name(master_fd: RawFd) -> io::Result<CString> {
         let mut buf = [0i8; 256];
         let result = unsafe { libc::ptsname_r(master_fd, buf.as_mut_ptr(), buf.len()) };
@@ -85,6 +86,19 @@ impl UnixPty {
         Ok(cstr.to_owned())
     }
 
+    /// Get the name of the slave PTY.
+    /// macOS doesn't have ptsname_r, use ptsname instead.
+    #[cfg(target_os = "macos")]
+    fn get_slave_name(master_fd: RawFd) -> io::Result<CString> {
+        let ptr = unsafe { libc::ptsname(master_fd) };
+        if ptr.is_null() {
+            return Err(io::Error::last_os_error());
+        }
+
+        let cstr = unsafe { std::ffi::CStr::from_ptr(ptr) };
+        Ok(cstr.to_owned())
+    }
+
     /// Setup the child process with the slave PTY.
     fn setup_child(slave_name: &CString, cmd: &str, args: &[&str], config: &PtyConfig) -> ! {
         // Create a new session
@@ -127,13 +141,15 @@ impl UnixPty {
         }
 
         // Set environment variables
+        // SAFETY: We are in the child process after fork, single-threaded at this point
         for (key, value) in &config.env {
-            std::env::set_var(key, value);
+            unsafe { std::env::set_var(key, value) };
         }
 
         // Set TERM if not already set
+        // SAFETY: We are in the child process after fork, single-threaded at this point
         if !config.env.contains_key("TERM") {
-            std::env::set_var("TERM", "xterm-256color");
+            unsafe { std::env::set_var("TERM", "xterm-256color") };
         }
 
         // Build the command arguments