fix: resolve clippy warnings in cortex-tui crate

- key_utils.rs: Use if expression for late init pattern
- consts.rs: Fix doc list item indentation
- rendering.rs: Remove unnecessary if branches with identical blocks
- action_bar.rs: Consolidate identical if branches
- backtrack_overlay.rs: Use clamp() instead of min().max()
- scrollable_dropdown.rs: Use clamp() instead of max().min()
- export.rs: Rename from_str to parse to avoid trait conflict
- login.rs: Use vec![] macro instead of push after init
- state.rs: Box large enum variant to reduce size
- methods.rs: Update to use Box::new for InteractiveState
- runner.rs: Collapse nested if let statements
- actions.rs: Use strip_prefix instead of starts_with + slice
- core.rs: Remove redundant if condition with identical branches
- input.rs: Collapse nested if, remove needless return statements

Author: echobt

src/cortex-tui/src/actions/key_utils.rs

@@ -14,10 +14,9 @@ use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
 pub fn parse_key_string(s: &str) -> Option<KeyEvent> {
     let parts: Vec<&str> = s.split('+').collect();
     let mut modifiers = KeyModifiers::NONE;
-    let key_part;
 
-    if parts.len() == 1 {
-        key_part = parts[0];
+    let key_part = if parts.len() == 1 {
+        parts[0]
     } else {
         // Parse modifiers
         for &part in &parts[..parts.len() - 1] {
@@ -29,8 +28,8 @@ pub fn parse_key_string(s: &str) -> Option<KeyEvent> {
                 _ => return None,
             }
         }
-        key_part = parts.last()?;
-    }
+        parts.last()?
+    };
 
     let code = parse_key_code(key_part)?;
     Some(KeyEvent::new(code, modifiers))

src/cortex-tui/src/app/methods.rs

@@ -559,7 +559,7 @@ impl AppState {
 
     /// Enter interactive mode with the given state.
     pub fn enter_interactive_mode(&mut self, state: crate::interactive::InteractiveState) {
-        self.input_mode = crate::interactive::InputMode::Interactive(state);
+        self.input_mode = crate::interactive::InputMode::Interactive(Box::new(state));
     }
 
     /// Exit interactive mode and return to normal input.

src/cortex-tui/src/interactive/builders/login.rs

@@ -110,15 +110,13 @@ pub fn build_login_selector(flow: &LoginFlowState) -> InteractiveState {
 
 /// Build interactive state for already logged in confirmation.
 pub fn build_already_logged_in_selector() -> InteractiveState {
-    let mut items = Vec::new();
-
-    items.push(InteractiveItem::new("__info__", "You are currently logged in").as_separator());
-    items.push(InteractiveItem::new("__spacer__", "").as_separator());
-    items.push(
+    let items = vec![
+        InteractiveItem::new("__info__", "You are currently logged in").as_separator(),
+        InteractiveItem::new("__spacer__", "").as_separator(),
         InteractiveItem::new("switch_account", "Login with another account")
             .with_description("Sign out and login again"),
-    );
-    items.push(InteractiveItem::new("cancel", "Cancel").with_description("Keep current session"));
+        InteractiveItem::new("cancel", "Cancel").with_description("Keep current session"),
+    ];
 
     InteractiveState::new(
         "Already Logged In",

src/cortex-tui/src/interactive/state.rs

@@ -11,7 +11,7 @@ pub enum InputMode {
     #[default]
     Normal,
     /// Interactive selection mode.
-    Interactive(InteractiveState),
+    Interactive(Box<InteractiveState>),
 }
 
 impl InputMode {

src/cortex-tui/src/runner/app_runner/runner.rs

@@ -537,11 +537,11 @@ impl AppRunner {
         app_state.org_name = org_name;
 
         // Load last used theme from config
-        if let Ok(config) = crate::providers::config::CortexConfig::load() {
-            if let Some(theme) = config.get_last_theme() {
-                app_state.set_theme(theme);
-                tracing::debug!("Loaded theme from config: {}", theme);
-            }
+        if let Ok(config) = crate::providers::config::CortexConfig::load()
+            && let Some(theme) = config.get_last_theme()
+        {
+            app_state.set_theme(theme);
+            tracing::debug!("Loaded theme from config: {}", theme);
         }
 
         // ====================================================================
@@ -814,11 +814,11 @@ impl AppRunner {
             .with_terminal_size(width, height);
 
         // Load last used theme from config
-        if let Ok(config) = crate::providers::config::CortexConfig::load() {
-            if let Some(theme) = config.get_last_theme() {
-                app_state.set_theme(theme);
-                tracing::debug!("Loaded theme from config: {}", theme);
-            }
+        if let Ok(config) = crate::providers::config::CortexConfig::load()
+            && let Some(theme) = config.get_last_theme()
+        {
+            app_state.set_theme(theme);
+            tracing::debug!("Loaded theme from config: {}", theme);
         }
 
         // Load session history from cortex-core
@@ -939,11 +939,11 @@ impl AppRunner {
             .with_terminal_size(width, height);
 
         // Load last used theme from config
-        if let Ok(config) = crate::providers::config::CortexConfig::load() {
-            if let Some(theme) = config.get_last_theme() {
-                app_state.set_theme(theme);
-                tracing::debug!("Loaded theme from config: {}", theme);
-            }
+        if let Ok(config) = crate::providers::config::CortexConfig::load()
+            && let Some(theme) = config.get_last_theme()
+        {
+            app_state.set_theme(theme);
+            tracing::debug!("Loaded theme from config: {}", theme);
         }
 
         // Create event loop WITHOUT session bridge

src/cortex-tui/src/runner/event_loop/actions.rs

@@ -22,9 +22,9 @@ impl EventLoop {
                 let text = self.app_state.input.submit();
                 if !text.is_empty() {
                     // Check for slash commands first
-                    if text.starts_with('/') {
+                    if let Some(stripped) = text.strip_prefix('/') {
                         // Check if command exists before executing
-                        let cmd_name = text[1..].split_whitespace().next().unwrap_or("");
+                        let cmd_name = stripped.split_whitespace().next().unwrap_or("");
                         if self.command_executor.registry().exists(cmd_name) {
                             // Valid command - record and execute
                             self.app_state.add_to_history(cmd_name);

src/cortex-tui/src/runner/event_loop/core.rs

@@ -722,13 +722,11 @@ impl EventLoop {
                 Ok(stored_servers) => {
                     for stored in stored_servers {
                         // Convert StoredMcpServer to McpServerInfo for display
+                        // Note: All servers start as Stopped regardless of enabled flag
+                        // They need to be explicitly started to become Running
                         let server_info = crate::modal::mcp_manager::McpServerInfo {
                             name: stored.name.clone(),
-                            status: if stored.enabled {
-                                crate::modal::mcp_manager::McpStatus::Stopped
-                            } else {
-                                crate::modal::mcp_manager::McpStatus::Stopped
-                            },
+                            status: crate::modal::mcp_manager::McpStatus::Stopped,
                             tool_count: 0,
                             error: None,
                             requires_auth: stored.api_key_env_var.is_some(),

src/cortex-tui/src/runner/event_loop/input.rs

@@ -267,10 +267,10 @@ impl EventLoop {
         let action = self.action_mapper.get_action(key_event, context);
 
         // Check if autocomplete is visible and handle its navigation
-        if self.app_state.autocomplete.visible {
-            if self.handle_autocomplete_key(key_event, terminal).await? {
-                return Ok(());
-            }
+        if self.app_state.autocomplete.visible
+            && self.handle_autocomplete_key(key_event, terminal).await?
+        {
+            return Ok(());
         }
 
         // Handle Copy action specially since it needs terminal access
@@ -352,12 +352,11 @@ impl EventLoop {
         // Priority 4: Double Ctrl+C to quit
         if self.app_state.handle_ctrl_c() {
             self.app_state.set_quit();
-            return Ok(());
         } else {
             self.app_state.toasts.info("Press Ctrl+C again to quit");
             self.render(terminal)?;
-            return Ok(());
         }
+        Ok(())
     }
 
     /// Handle ESC key with double-tap to quit
@@ -401,12 +400,12 @@ impl EventLoop {
             KeyCode::Up => {
                 self.app_state.autocomplete.select_prev();
                 self.render(terminal)?;
-                return Ok(true);
+                Ok(true)
             }
             KeyCode::Down => {
                 self.app_state.autocomplete.select_next();
                 self.render(terminal)?;
-                return Ok(true);
+                Ok(true)
             }
             KeyCode::Tab => {
                 // Accept completion with Tab only
@@ -439,7 +438,7 @@ impl EventLoop {
                 }
                 self.app_state.autocomplete.hide();
                 self.render(terminal)?;
-                return Ok(true);
+                Ok(true)
             }
             KeyCode::Enter => {
                 // Enter completes and immediately executes the command
@@ -468,16 +467,16 @@ impl EventLoop {
                 }
                 self.app_state.autocomplete.hide();
                 // Don't return - fall through to execute the command
-                return Ok(false);
+                Ok(false)
             }
             KeyCode::Esc => {
                 self.app_state.autocomplete.hide();
                 self.render(terminal)?;
-                return Ok(true);
+                Ok(true)
             }
             _ => {
                 // Continue to normal handling, which will update autocomplete
-                return Ok(false);
+                Ok(false)
             }
         }
     }

src/cortex-tui/src/session/export.rs

@@ -46,7 +46,7 @@ impl ExportFormat {
     }
 
     /// Parses a format from string.
-    pub fn from_str(s: &str) -> Option<Self> {
+    pub fn parse(s: &str) -> Option<Self> {
         match s.to_lowercase().as_str() {
             "md" | "markdown" => Some(ExportFormat::Markdown),
             "json" => Some(ExportFormat::Json),
@@ -383,13 +383,13 @@ mod tests {
 
     #[test]
     fn test_format_from_str() {
-        assert_eq!(ExportFormat::from_str("md"), Some(ExportFormat::Markdown));
+        assert_eq!(ExportFormat::parse("md"), Some(ExportFormat::Markdown));
         assert_eq!(
-            ExportFormat::from_str("markdown"),
+            ExportFormat::parse("markdown"),
             Some(ExportFormat::Markdown)
         );
-        assert_eq!(ExportFormat::from_str("json"), Some(ExportFormat::Json));
-        assert_eq!(ExportFormat::from_str("txt"), Some(ExportFormat::Text));
-        assert_eq!(ExportFormat::from_str("unknown"), None);
+        assert_eq!(ExportFormat::parse("json"), Some(ExportFormat::Json));
+        assert_eq!(ExportFormat::parse("txt"), Some(ExportFormat::Text));
+        assert_eq!(ExportFormat::parse("unknown"), None);
     }
 }

src/cortex-tui/src/ui/consts.rs

@@ -54,6 +54,7 @@ pub const SPINNER_FRAMES: &[char] = &['⠋', '⠙', '⠹', '⠸', '⠼', '⠴',
 /// Spinner animation frames for streaming ("breathing" pattern).
 /// Ordered by visual weight for smooth animation:
 /// - · (point) → ✢ (cross) → ✻ (thin asterisk) → ✽ (heavy asterisk)
+///
 /// Uses ping-pong pattern for fluid "breathing" effect.
 /// Soft/organic variant without pointed star (✶) for smoother curves.
 pub const STREAMING_SPINNER_FRAMES: &[char] = &[