fix: resolve clippy warnings in cortex-tui crate

- Remove unused KeyModifiers import in theme.rs (keep in tests)
- Replace deprecated buf.get(x, y) with buf[(x, y)] indexing
- Collapse nested if statements using let..&& pattern
- Convert let..else to ? operator where applicable
- Replace match with single arm to if let
- Replace len() > 0 with !is_empty()
- Remove unnecessary .clone() on Copy types
- Remove useless .into() conversions
- Use Range::contains() instead of manual comparison

Author: echobt

src/cortex-tui/src/cards/help.rs

@@ -586,7 +586,7 @@ mod tests {
 
         // Should have fewer items
         assert!(card.filtered_items.len() < initial_count);
-        assert!(card.filtered_items.len() > 0);
+        assert!(!card.filtered_items.is_empty());
     }
 
     #[test]

src/cortex-tui/src/modal/commands.rs

@@ -885,23 +885,23 @@ mod tests {
 
         // Navigate down to second command
         let down = KeyEvent::new(KeyCode::Down, KeyModifiers::NONE);
-        modal.handle_key(down.clone());
+        modal.handle_key(down);
         let second = modal.selected_command().unwrap();
         assert_eq!(
             second.name, "export",
             "Second command should be 'export' (Session category)"
         );
 
         // Navigate down to third command
-        modal.handle_key(down.clone());
+        modal.handle_key(down);
         let third = modal.selected_command().unwrap();
         assert_eq!(
             third.name, "model",
             "Third command should be 'model' (Model category)"
         );
 
         // Navigate down to fourth command
-        modal.handle_key(down.clone());
+        modal.handle_key(down);
         let fourth = modal.selected_command().unwrap();
         assert_eq!(
             fourth.name, "settings",

src/cortex-tui/src/modal/theme.rs

@@ -3,7 +3,7 @@
 //! A modal for selecting the application theme (dark, light, ocean_dark, monokai).
 
 use cortex_core::style::{CYAN_PRIMARY, SURFACE_0, TEXT, TEXT_DIM, VOID};
-use crossterm::event::{KeyCode, KeyEvent, KeyModifiers};
+use crossterm::event::{KeyCode, KeyEvent};
 use ratatui::buffer::Buffer;
 use ratatui::layout::Rect;
 use ratatui::style::Style;
@@ -251,6 +251,7 @@ impl Modal for ThemeSelectorModal {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crossterm::event::KeyModifiers;
 
     #[test]
     fn test_theme_selector_new() {
@@ -372,7 +373,7 @@ mod tests {
 
         // Navigate to ocean_dark (index 2)
         let down = KeyEvent::new(KeyCode::Down, KeyModifiers::NONE);
-        modal.handle_key(down.clone());
+        modal.handle_key(down);
         modal.handle_key(down);
         assert_eq!(modal.selected_theme_id(), Some("ocean_dark"));
 

src/cortex-tui/src/runner/event_loop/mouse.rs

@@ -21,17 +21,17 @@ impl EventLoop {
         match action {
             MouseAction::Click { x, y, button } => {
                 // Handle interactive mode clicks
-                if self.app_state.is_interactive_mode() {
-                    if let Some((action, item_id, item_ids)) = self.handle_interactive_click(x, y) {
-                        let keep_open = self
-                            .handle_interactive_selection(action, item_id, item_ids)
-                            .await;
-                        if !keep_open {
-                            self.app_state.exit_interactive_mode();
-                        }
-                        self.render(terminal)?;
-                        return Ok(());
+                if self.app_state.is_interactive_mode()
+                    && let Some((action, item_id, item_ids)) = self.handle_interactive_click(x, y)
+                {
+                    let keep_open = self
+                        .handle_interactive_selection(action, item_id, item_ids)
+                        .await;
+                    if !keep_open {
+                        self.app_state.exit_interactive_mode();
                     }
+                    self.render(terminal)?;
+                    return Ok(());
                 }
 
                 // Handle question view clicks
@@ -100,15 +100,15 @@ impl EventLoop {
 
             MouseAction::Move { x, y } => {
                 // Handle hover effects for interactive mode
-                if self.app_state.is_interactive_mode() {
-                    if let Some(state) = self.app_state.get_interactive_state_mut() {
-                        if let Some(idx) = state.hit_test(x, y) {
-                            if state.hovered != Some(idx) {
-                                state.hovered = Some(idx);
-                            }
-                        } else if state.hovered.is_some() {
-                            state.hovered = None;
+                if self.app_state.is_interactive_mode()
+                    && let Some(state) = self.app_state.get_interactive_state_mut()
+                {
+                    if let Some(idx) = state.hit_test(x, y) {
+                        if state.hovered != Some(idx) {
+                            state.hovered = Some(idx);
                         }
+                    } else if state.hovered.is_some() {
+                        state.hovered = None;
                     }
                 }
 
@@ -189,9 +189,7 @@ impl EventLoop {
         x: u16,
         y: u16,
     ) -> Option<(crate::interactive::InteractiveAction, String, Vec<String>)> {
-        let Some(state) = self.app_state.get_interactive_state_mut() else {
-            return None;
-        };
+        let state = self.app_state.get_interactive_state_mut()?;
 
         // Check if click is on a tab first
         if let Some(tab_idx) = state.hit_test_tab(x, y) {
@@ -209,9 +207,7 @@ impl EventLoop {
         }
 
         // Hit test using stored click zones
-        let Some(idx) = state.hit_test(x, y) else {
-            return None;
-        };
+        let idx = state.hit_test(x, y)?;
 
         // Move selection to clicked item
         state.selected = idx;

src/cortex-tui/src/runner/event_loop/rendering.rs

@@ -15,10 +15,10 @@ impl EventLoop {
     /// Renders the current view to the terminal.
     pub(super) fn render(&mut self, terminal: &mut CortexTerminal) -> Result<()> {
         // Check if scrollback clear was requested
-        if self.app_state.take_pending_scrollback_clear() {
-            if let Err(e) = terminal.clear_scrollback() {
-                tracing::warn!("Failed to clear terminal scrollback: {}", e);
-            }
+        if self.app_state.take_pending_scrollback_clear()
+            && let Err(e) = terminal.clear_scrollback()
+        {
+            tracing::warn!("Failed to clear terminal scrollback: {}", e);
         }
 
         // Sync streaming content from stream controller to app state
@@ -316,12 +316,9 @@ impl EventLoop {
                 if let Some(modal) = active_modal {
                     use crate::app::ActiveModal;
                     use crate::widgets::ModelPicker;
-                    match modal {
-                        ActiveModal::ModelPicker => {
-                            let picker = ModelPicker::new(&self.app_state.model_picker);
-                            frame.render_widget(picker, area);
-                        }
-                        _ => {}
+                    if let ActiveModal::ModelPicker = modal {
+                        let picker = ModelPicker::new(&self.app_state.model_picker);
+                        frame.render_widget(picker, area);
                     }
                 }
 

src/cortex-tui/src/runner/event_loop/tools.rs

@@ -368,11 +368,13 @@ impl EventLoop {
         }
 
         // Handle billing events specially
-        if name == "billing" && id == "billing" && success {
-            if let Some(data_str) = output.strip_prefix("billing:data:") {
-                self.handle_billing_data(data_str);
-                return;
-            }
+        if name == "billing"
+            && id == "billing"
+            && success
+            && let Some(data_str) = output.strip_prefix("billing:data:")
+        {
+            self.handle_billing_data(data_str);
+            return;
         }
 
         tracing::debug!(

src/cortex-tui/src/views/approval.rs

@@ -620,21 +620,21 @@ mod tests {
     fn test_determine_value_style() {
         // Boolean
         let style = determine_value_style("true");
-        assert_eq!(style.fg, Some(ORANGE.into()));
+        assert_eq!(style.fg, Some(ORANGE));
 
         let style = determine_value_style("false");
-        assert_eq!(style.fg, Some(ORANGE.into()));
+        assert_eq!(style.fg, Some(ORANGE));
 
         // Null
         let style = determine_value_style("null");
-        assert_eq!(style.fg, Some(RED.into()));
+        assert_eq!(style.fg, Some(RED));
 
         // Number
         let style = determine_value_style("42");
-        assert_eq!(style.fg, Some(YELLOW.into()));
+        assert_eq!(style.fg, Some(YELLOW));
 
         let style = determine_value_style("3.14");
-        assert_eq!(style.fg, Some(YELLOW.into()));
+        assert_eq!(style.fg, Some(YELLOW));
     }
 
     #[test]

src/cortex-tui/src/views/minimal_session/tests.rs

@@ -69,7 +69,7 @@ mod tests {
         let mut has_content = false;
         for y in 0..24 {
             for x in 0..80 {
-                let symbol = buf.get(x, y).symbol();
+                let symbol = buf[(x, y)].symbol();
                 if !symbol.trim().is_empty() && symbol != " " {
                     has_content = true;
                     break;

src/cortex-tui/src/widgets/command_palette/fuzzy.rs

@@ -83,7 +83,7 @@ mod tests {
     #[test]
     fn test_fuzzy_score_prefix_match() {
         let score = fuzzy_score("hel", "help").unwrap();
-        assert!(score >= 500 && score < 1000);
+        assert!((500..1000).contains(&score));
     }
 
     #[test]

src/cortex-tui/src/widgets/key_hints.rs

@@ -491,7 +491,7 @@ mod tests {
 
         // Check that content was rendered
         let content: String = (0..80)
-            .map(|x| buf.get(x, 0).symbol().chars().next().unwrap_or(' '))
+            .map(|x| buf[(x, 0)].symbol().chars().next().unwrap_or(' '))
             .collect();
         assert!(content.contains("commands"));
         assert!(content.contains("help"));
@@ -506,7 +506,7 @@ mod tests {
         hints.render(area, &mut buf);
 
         let content: String = (0..80)
-            .map(|x| buf.get(x, 0).symbol().chars().next().unwrap_or(' '))
+            .map(|x| buf[(x, 0)].symbol().chars().next().unwrap_or(' '))
             .collect();
         assert!(content.contains("interrupt"));
     }
@@ -520,7 +520,7 @@ mod tests {
         hints.render(area, &mut buf);
 
         let content: String = (0..80)
-            .map(|x| buf.get(x, 0).symbol().chars().next().unwrap_or(' '))
+            .map(|x| buf[(x, 0)].symbol().chars().next().unwrap_or(' '))
             .collect();
         assert!(content.contains("approve"));
         assert!(content.contains("reject"));