Skip to content

fix(ci): improve macOS cache detection for Swatinem/rust-cache #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echobt merged 2 commits into from
Feb 3, 2026
Merged

fix(ci): improve macOS cache detection for Swatinem/rust-cache #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72146b6
fix(ci): improve macOS cache detection for Swatinem/rust-cache
echobt Feb 3, 2026
5ad1188
fix: resolve flaky tests in CI for config_discovery and batch handlers
echobt Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ jobs:
if: "!contains(matrix.runner, 'blacksmith')"
uses: Swatinem/rust-cache@v2
with:
prefix-key: "rust-test-${{ matrix.name }}"
shared-key: ${{ needs.setup-cache.outputs.cache-key }}
prefix-key: "v1-rust-test"
shared-key: "${{ matrix.name }}-${{ hashFiles('**/Cargo.lock', '**/Cargo.toml') }}"
Comment on lines +136 to +137

@greptile-apps greptile-apps Bot Feb 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that .github/workflows/release.yml at lines 145-150 also needs the same fix, as it has macOS runners using Swatinem/rust-cache@v2 with the old pattern (shared-key: ${{ needs.prepare.outputs.cache_key }})

Prompt To Fix With AI 
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 136:137

Comment:
check that `.github/workflows/release.yml` at lines 145-150 also needs the same fix, as it has macOS runners using `Swatinem/rust-cache@v2` with the old pattern (`shared-key: ${{ needs.prepare.outputs.cache_key }}`)

How can I resolve this? If you propose a fix, please make it concise.


- name: Run tests
run: cargo +nightly test --workspace --all-features
Expand Down Expand Up @@ -181,8 +181,8 @@ jobs:
if: "!contains(matrix.runner, 'blacksmith')"
uses: Swatinem/rust-cache@v2
with:
prefix-key: "rust-build-${{ matrix.name }}"
shared-key: ${{ needs.setup-cache.outputs.cache-key }}
prefix-key: "v1-rust-build"
shared-key: "${{ matrix.name }}-${{ hashFiles('**/Cargo.lock', '**/Cargo.toml') }}"

- name: Check build
run: cargo +nightly check --workspace --all-features
Expand Down
Loading