Skip to content

Honor DAG command execution context#374

Closed
GreyforgeLabs wants to merge 2 commits into
CortexLM:mainfrom
GreyforgeLabs:fix-dag-executor-windows-shell
Closed

Honor DAG command execution context#374
GreyforgeLabs wants to merge 2 commits into
CortexLM:mainfrom
GreyforgeLabs:fix-dag-executor-windows-shell

Conversation

@GreyforgeLabs

@GreyforgeLabs GreyforgeLabs commented May 20, 2026

Copy link
Copy Markdown

Summary

  • choose the DAG task shell by platform before executing task commands
  • use cmd.exe /C on Windows and keep sh -c on Unix-like systems
  • parse task-level working_dir and run command tasks from that directory

Fixes PlatformNetwork/bounty-challenge#53151
Fixes PlatformNetwork/bounty-challenge#52613

Tests

  • cargo fmt --package cortex-cli --check
  • git diff --check
  • cargo check -p cortex-cli --no-default-features --features cortex-tui
  • cargo run -p cortex-cli --no-default-features --features cortex-tui --bin Cortex -- dag run --file /tmp/cortex-dag-shell-smoke.yaml --strategy sequential --quiet
  • cargo run -p cortex-cli --no-default-features --features cortex-tui --bin Cortex -- dag run --file /tmp/cortex-dag-working-dir.yaml --strategy sequential --quiet
  • tr -d "\r\n" < /tmp/cortex-dag-working-dir-output.txt # output: /tmp

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@GreyforgeLabs GreyforgeLabs changed the title Use platform shell for DAG commands Honor DAG command execution context May 20, 2026
@GreyforgeLabs GreyforgeLabs closed this by deleting the head repository May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant