Skip to content

Commit f7fd394

Browse files
committed
fix(review): address review comments
1 parent 24e3b90 commit f7fd394

7 files changed

Lines changed: 791 additions & 1231 deletions

File tree

.cargo/audit.toml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,4 @@ ignore = [
99
"RUSTSEC-2025-0009",
1010
"RUSTSEC-2025-0010",
1111
"RUSTSEC-2023-0071",
12-
# rustls-webpki 0.101.7 via hyper-rustls 0.24 / rustls 0.21 (hyper 0.14 transitive dependency).
13-
# KMS does not use CRLs, does not assert URI SANs, and exploiting wildcard name constraints
14-
# requires certificate misissuance upstream.
15-
"RUSTSEC-2026-0098",
16-
"RUSTSEC-2026-0099",
17-
"RUSTSEC-2026-0104",
1812
]

.github/scripts/nix.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,24 +513,24 @@ test_command() {
513513
SCRIPT="$REPO_ROOT/.github/scripts/test/test_secret_vault.sh"
514514
;;
515515
secret_aws)
516-
SCRIPT="$REPO_ROOT/.github/scripts/test/test_secret_aws.sh"
517516
for var in AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_REGION; do
518517
if [ -z "${!var:-}" ]; then
519518
echo "Error: Required environment variable $var is not set" >&2
520519
echo "AWS SSM secret backend tests require AWS credentials." >&2
521520
exit 1
522521
fi
523522
done
523+
SCRIPT="$REPO_ROOT/.github/scripts/test/test_secret_aws.sh"
524524
;;
525525
secret_azure)
526-
SCRIPT="$REPO_ROOT/.github/scripts/test/test_secret_azure.sh"
527526
for var in AZURE_TENANT_ID AZURE_CLIENT_ID AZURE_CLIENT_SECRET AZURE_KV_NAME; do
528527
if [ -z "${!var:-}" ]; then
529528
echo "Error: Required environment variable $var is not set" >&2
530529
echo "Azure KV secret backend tests require Azure credentials." >&2
531530
exit 1
532531
fi
533532
done
533+
SCRIPT="$REPO_ROOT/.github/scripts/test/test_secret_azure.sh"
534534
;;
535535
ui)
536536
SCRIPT="$REPO_ROOT/.github/scripts/test/test_ui.sh"

.github/workflows/test_all.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- secret_vault
3737
- secret_aws
3838
- secret_azure
39-
features: [ fips, non-fips ]
39+
features: [fips, non-fips]
4040
exclude:
4141
# redis is exclusively for non-fips
4242
- type: redis
@@ -155,8 +155,9 @@ jobs:
155155
# give it a fixed concurrency group so only one job runs at a time across all PRs.
156156
# utimaco and softhsm2 use a per-run group so they are never blocked by other PRs.
157157
concurrency:
158-
group: ${{ matrix.hsm-type == 'proteccio' && 'hsm-proteccio' ||
159-
format('hsm-{0}-{1}', matrix.hsm-type, github.run_id) }}
158+
group:
159+
${{ (matrix.hsm-type == 'proteccio' && 'hsm-proteccio') || (matrix.hsm-type == 'crypt2pay' && 'hsm-crypt2pay') || format('hsm-{0}-{1}', matrix.hsm-type,
160+
github.run_id) }}
160161
cancel-in-progress: false
161162
strategy:
162163
fail-fast: false
@@ -166,7 +167,7 @@ jobs:
166167
- proteccio
167168
- softhsm2
168169
- crypt2pay
169-
features: [ fips, non-fips ]
170+
features: [fips, non-fips]
170171
exclude:
171172
# parallel connections on proteccio is not supported
172173
- hsm-type: proteccio

0 commit comments

Comments
 (0)