[auto-rotation feature] feat: add key auto-rotation specification + manual rotation for all key types#968
Open
Manuthor wants to merge 3 commits into
Open
[auto-rotation feature] feat: add key auto-rotation specification + manual rotation for all key types#968Manuthor wants to merge 3 commits into
Manuthor wants to merge 3 commits into
Conversation
6cc8ce5 to
fa12cc6
Compare
Add comprehensive specification for scheduled key rotation covering: - 6 rotation scenarios (plain, wrapping, wrapped, asymmetric, CoverCrypt, KEK) - Rotation policy vendor attributes (x-rotate-interval, etc.) - Server-side cron scheduler - KMIP attribute tables (auto vs manual rotation semantics) - Implementation roadmap (5 stacked PRs) Ref: #900
…s + test vectors (#969) * feat(rekey): implement symmetric key ReKey with wrapping key re-wrap - Implement KMIP ReKey for symmetric keys with name transfer per §4.4 - Support re-wrapping dependent keys when a wrapping key is rekeyed - Add find_wrapped_by() to ObjectsStore trait (SQLite, PostgreSQL, MySQL) - Fix: transfer Name attribute from old to new key during ReKey - Fix: error on self-wrap when wrapping_key_id is user-supplied - Fix: bypass ownership check for server-configured KEK Tested with 37 vector tests (9 symmetric + 27 keypair + 1 security) * fix: consolidate rekey operations using trait * feat: consolidate Recertify operation
…4 (merge spec+manual into PR1)
fa12cc6 to
5f27e21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delivers the complete key auto-rotation specification and the full manual-rotation
implementation for all key types.
This is PR 1 of 4 in the key auto-rotation feature stack:
What's included
Documentation
x-rotate-interval,x-rotate-name,x-rotate-offset,x-rotate-generation,x-rotate-date)wrapped key, asymmetric key pair, wrapped private key (CoverCrypt),
certificate renewal (
ReCertify), server-wide KEKReplacementObjectLink/ReplacedObjectLink)Implementation —
Re-Key,Re-Key Key Pair,Re-CertifyComplete manual-rotation implementation for all six scenarios:
(RSA, EC, ML-KEM, ML-DSA, SLH-DSA, X25519, secp256k1, CoverCrypt)
Implements
ReCertify(KMIP 2.1 §6.1.45) for certificate renewal:ReplacedObjectLink/ReplacementObjectLink)PreActivestate for future-activation certificatesAll 344 test vectors pass.
Breaking changes
None.
Reviewer notes
This document is the canonical reference for all subsequent PRs in this stack.
Please review terminology and attribute semantics carefully; changes here will
cascade to the implementation PRs.