fix: raise constructed exceptions that were silently discarded

Several guard clauses constructed an exception object but never raised
it, so the error path fell through instead of failing loud. For the
PSFEx interpolation runner (#785) this meant a typo'd MODE skipped all
branches, returned (None, None), and let the pipeline record success
with no interpolated PSF catalogue.

Add the missing `raise` at every site found by grepping src for
constructed-but-unraised exceptions:

- modules/psfex_interp_runner.py  invalid MODE (#785)
- modules/mccd_interp_runner.py   invalid MODE (x2: VALIDATION + else)
- modules/mask_package/mask.py    invalid mask type
- pipeline/file_handler.py        non-str match pattern
- pipeline/file_io.py             non-ndarray col_data

Closes #785

Co-Authored-By: Claude <noreply@anthropic.com>

Author: cailmdaley

src/shapepipe/modules/mask_package/mask.py

@@ -1070,7 +1070,7 @@ def _exec_WW(self, types="HALO"):
                 self._WW_stdout, self._WW_stderr = execute(cmd)
 
         else:
-            ValueError("Types must be in ['HALO','SPIKE','ALL']")
+            raise ValueError("Types must be in ['HALO','SPIKE','ALL']")
 
         if (self._WW_stderr != "") or (self._rm_reg_stderr != ""):
             self._err = True

src/shapepipe/modules/mccd_interp_runner.py

@@ -114,13 +114,13 @@ def mccd_interp_runner(
         inst.process_me(psf_model_dir, psf_model_pattern, f_wcs_path)
 
     elif mode == "VALIDATION":
-        ValueError(
+        raise ValueError(
             "MODE has to be in MULTI-EPOCH or CLASSIC. For validation"
             + " use MCCD validation runner."
         )
 
     else:
-        ValueError("MODE has to be in : [CLASSIC, MULTI-EPOCH]")
+        raise ValueError("MODE has to be in : [CLASSIC, MULTI-EPOCH]")
 
     # No return objects
     return None, None

src/shapepipe/modules/psfex_interp_runner.py

@@ -150,7 +150,7 @@ def psfex_interp_runner(
 
     else:
         # Raise error for invalid run mode
-        ValueError("MODE has to be in : [CLASSIC, MULTI-EPOCH, VALIDATION]")
+        raise ValueError("MODE has to be in : [CLASSIC, MULTI-EPOCH, VALIDATION]")
 
     # No return objects
     return None, None

src/shapepipe/pipeline/file_handler.py

@@ -792,7 +792,7 @@ def _generate_re_pattern(match_pattern):
 
         """
         if not isinstance(match_pattern, str):
-            TypeError("Match pattern must be a string.")
+            raise TypeError("Match pattern must be a string.")
 
         chars = [char for char in match_pattern if not char.isalnum()]
         split_pattern = "|".join(chars).replace(".", r"\.")

src/shapepipe/pipeline/file_io.py

@@ -1389,7 +1389,7 @@ def add_col(
             )
 
         if type(col_data) != np.ndarray:
-            TypeError("col_data must be a numpy.ndarray")
+            raise TypeError("col_data must be a numpy.ndarray")
 
         if hdu_no is None:
             hdu_no = self.hdu_no